Page MenuHomePhabricator
Create Task
Maniphest T357799

[DOT] Add redirect-related parameters to API modules and return redirect URL (if any) in WikibaseLexeme editing APIs
Closed, ResolvedPublic
Actions

Description

Just like T357024, but for WikibaseLexeme’s dedicated APIs.

The API modules can be found in Registrar.php; they are: wbladdform, wblremoveform, wbleditformelements, wbladdsense, wblremovesense, wbleditsenseelements, wblmergelexemes.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add temp user redirect parameters to API modulesmediawiki/extensions/WikibaseLexememaster+221 -88
Add strict types to touched filesmediawiki/extensions/WikibaseLexememaster+161 -410
Correctly support temp users when merging lexemesmediawiki/extensions/WikibaseLexememaster+249 -41
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Feb 16 2024, 5:34 PM
Lucas_Werkmeister_WMDE mentioned this in T357020: [DOT] Perform necessary redirects after creating temporary account in Wikidata-related extensions.
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Feb 16 2024, 5:37 PM
Lucas_Werkmeister_WMDE moved this task from In Task Breakdown to Ready for Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
Maintenance_bot moved this task from Incoming to Ongoing on the wmde-wikidata-tech board.Feb 16 2024, 6:29 PM
Lucas_Werkmeister_WMDE mentioned this in T358323: [DOT] Perform necessary redirect after editing lexeme data in view interface.Feb 23 2024, 10:41 AM
Lucas_Werkmeister_WMDE claimed this task.Feb 28 2024, 5:07 PM
Lucas_Werkmeister_WMDE moved this task from Ready for Development to In Development on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
gerritbot added a comment.Feb 28 2024, 5:07 PM

Change 1003800 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Correctly thread temp users on lexeme merge

https://gerrit.wikimedia.org/r/1003800

gerritbot added a project: Patch-For-Review.Feb 28 2024, 5:07 PM

Change 1007402 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] WIP: Add temp user redirect parameters to API modules

https://gerrit.wikimedia.org/r/1007402

gerritbot added a comment.Feb 29 2024, 3:30 PM

Change 1007634 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/WikibaseLexeme@master] Add strict types to touched files

https://gerrit.wikimedia.org/r/1007634

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Mar 1 2024, 9:19 AM
Lucas_Werkmeister_WMDE moved this task from In Development to Ready for Peer Review on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.
ArthurTaylor moved this task from Ready for Peer Review to Ready for Tech Verification on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.Mar 1 2024, 10:35 AM
gerritbot added a comment.Mar 1 2024, 10:52 AM

Change 1003800 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Correctly support temp users when merging lexemes

https://gerrit.wikimedia.org/r/1003800

gerritbot added a comment.Mar 1 2024, 10:57 AM

Change 1007402 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add temp user redirect parameters to API modules

https://gerrit.wikimedia.org/r/1007402

gerritbot added a comment.Mar 1 2024, 10:57 AM

Change 1007634 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add strict types to touched files

https://gerrit.wikimedia.org/r/1007634

Lucas_Werkmeister_WMDE closed this task as Resolved.Mar 1 2024, 11:00 AM
Lucas_Werkmeister_WMDE claimed this task.
Lucas_Werkmeister_WMDE moved this task from Ready for Tech Verification to Done on the [Archived]Wikidata Dev Team (Wikidata.org Slice) board.

I think we can close this directly, it’ll effectively be verified via T358323.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.21; 2024-03-05).Mar 1 2024, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Mar 1 2024, 11:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits