Maniphest T357808

LinkRendererTest references non existent LinkTarget class
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Feb 16 2024, 7:00 PM

Project Tags

Referenced Files

None

Subscribers

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	LinkRendererTest: Add missing import for LinkTarget	Reedy	mediawiki/core	REL1_39	+2 -1
	LinkRendererTest: Add missing import for LinkTarget	Reedy	mediawiki/core	REL1_41	+2 -1
	LinkRendererTest: Add missing import for LinkTarget	Reedy	mediawiki/core	master	+2 -1
	LinkRendererTest: Add missing import for LinkTarget	Reedy	mediawiki/core	REL1_40	+2 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMEXT1004176e4f3c: Updated mediawiki/extensions Project: mediawiki/extensions/Configure…
rMWc9d885f3b457: Namespace LinkTarget under MediaWiki\Linker
rMW9dc884a130e0: Pass PageReference as possible parameter to LinkRenderer methods

Event Timeline

Reedy created this task.Feb 16 2024, 7:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 16 2024, 7:00 PM

Reedy triaged this task as Low priority.Feb 16 2024, 7:00 PM

Change 1004231 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@master] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004231

gerritbot added a project: Patch-For-Review.Feb 16 2024, 7:02 PM

Broken since the line was added in rMW9dc884a130e0: Pass PageReference as possible parameter to LinkRenderer methods (May 2021)? Class was already namespaced in rMWc9d885f3b457: Namespace LinkTarget under MediaWiki\Linker (April 2016).

Change 1004231 merged by jenkins-bot:

[mediawiki/core@master] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004231

Reedy closed this task as Resolved.Feb 16 2024, 11:04 PM

Reedy claimed this task.

Change 1004175 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_41] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004175

Change 1004176 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_40] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004176

Change 1004177 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/core@REL1_39] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004177

Change 1004176 merged by jenkins-bot:

[mediawiki/core@REL1_40] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004176

Change 1004175 merged by jenkins-bot:

[mediawiki/core@REL1_41] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004175

Change 1004177 merged by jenkins-bot:

[mediawiki/core@REL1_39] LinkRendererTest: Add missing import for LinkTarget

https://gerrit.wikimedia.org/r/1004177

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2024, 12:30 AM

ReleaseTaggerBot added projects: MW-1.41-notes, MW-1.42-notes (1.42.0-wmf.19; 2024-02-20), MW-1.39-notes, MW-1.40-notes.Feb 17 2024, 1:00 AM