Page MenuHomePhabricator

Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts
Closed, ResolvedPublic2 Estimated Story Points

Description

The GlobalBlockLocalStatusLookup service allows callers to lookup the local status of a given global block. This can be done either by the ID of the global block in the globalblocks table or (importantly for this task) the address which is the specific target of the block. The service also provides a method named ::getLocalWhitelistInfoByIP which allows callers to lookup a block by just the IP address target of the block, which likely needs to renamed to make it clear that the blocks can target more than just IP addresses (or ranges).

The GlobalBlockLocalStatusManager service allows callers to manage whether a global block is locally disabled. The service needs to write to the gbw_target_central_id column and use an alternative error message key if no global block exists on a target.

Acceptance criteria
  • Update the GlobalBlockLocalStatusLookup service to support global blocks on accounts
  • Update the GlobalBlockLocalStatusManager service to support global blocks on accounts

Related Objects

StatusSubtypeAssignedTask
In ProgressNiharika
OpenNone
OpenNone
OpenNone
ResolvedDreamy_Jazz
OpenNone
DuplicateNone
OpenSkizzerz
OpenDreamy_Jazz
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenDreamy_Jazz
ResolvedDreamy_Jazz
OpenDreamy_Jazz
OpenDreamy_Jazz
OpenNone
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedMarostegui
ResolvedMarostegui
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz
ResolvedDreamy_Jazz

Event Timeline

Change 1006911 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/GlobalBlocking@master] [WIP] Update GlobalBlockLocalStatusLookup for account blocks

https://gerrit.wikimedia.org/r/1006911

Dreamy_Jazz renamed this task from Update the GlobalBlockLocalStatusLookup service to support blocking accounts to Update the GlobalBlockLocalStatusLookup and GlobalBlockLocalStatusManager services to support blocking accounts.Mar 5 2024, 3:56 PM
Dreamy_Jazz updated the task description. (Show Details)

Change #1006911 merged by jenkins-bot:

[mediawiki/extensions/GlobalBlocking@master] Update GlobalBlockLocalStatusLookup and Manager for account blocks

https://gerrit.wikimedia.org/r/1006911