Parsoid redlink/self-link pass is currently not doing anything special around language conversion for redlinks and self-links, and it probably should. To be done:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Bump wikimedia/parsoid to 0.20.0-a11 | mediawiki/vendor | master | +361 -419 | |
| Add selflink classes to variant resolved links | mediawiki/services/parsoid | master | +10 -22 |
Three test articles:
| From \ To | [[Č]] | [[Budimpešta]] | [[Budimpešt]] |
|---|---|---|---|
| Ч | Blue link to Č | Blue link to Будимпешта, link text is Budimpešta | Red link to Budimpešt |
| Будимпешта | Blue link to Č | Self-link, link text is Budimpešta | Red link to Budimpešt |
So
Red link and self-link detection runs after the above normalization, but the link text is determined before the normalization.
(I don’t know what happens if the given variant doesn’t exist, but multiple other variants do, as Serbian has only two variants, and I can’t read Chinese.)
I hope this Phase 5: (Later) doesn’t mean Parsoid read views will be enabled on wikis with language conversion (even in talk namespaces) before this is done.
T53587: Parsoid needs to run findVariantLink or some equivalent thing and T258856: Links to variants titles in Parsoid are still marked as red links are related and https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/738019 seems to fix this, although we ran into a glitch there which we are discussing.
Yes, we won't enable parsoid readviews on a lang-variant wiki without lang variant handling fixed everywhere it is broken in Parsoid.
and https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/738019 seems to fix this
The selflink part is still a TODO,
https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/738019/comment/0c6568d4_04b9cdae/
Change #1046763 had a related patch set uploaded (by Arlolra; author: Arlolra):
[mediawiki/services/parsoid@master] Add selflink classes to variant resolved links
Change #1046763 merged by jenkins-bot:
[mediawiki/services/parsoid@master] Add selflink classes to variant resolved links
Change #1051079 had a related patch set uploaded (by Isabelle Hurbain-Palatin; author: Isabelle Hurbain-Palatin):
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a11
Change #1051079 merged by jenkins-bot:
[mediawiki/vendor@master] Bump wikimedia/parsoid to 0.20.0-a11