Page MenuHomePhabricator
Create Task
Maniphest T358252

Codex CSS buttons in mobile editor have uneven vertical padding
Closed, ResolvedPublic
Actions

Description

  1. Launch the mobile editor while logged out
  2. There is more padding below button text than above it:

image.png (320×439 px, 30 KB)

From and old patch demo wiki (correct alignment):

image.png (320×439 px, 27 KB)

Details

SubjectRepoBranchLines +/-
Tweak vertical alignment of "block" buttonsmediawiki/extensions/MobileFrontendmaster+3 -2
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Feb 22 2024, 5:09 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 22 2024, 5:09 PM
Esanders updated the task description. (Show Details)Feb 22 2024, 5:11 PM
Esanders updated the task description. (Show Details)
gerritbot added a comment.Feb 22 2024, 5:23 PM

Change 1005804 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MobileFrontend@master] Tweak vertical alignment of "block" buttons

https://gerrit.wikimedia.org/r/1005804

gerritbot added a project: Patch-For-Review.Feb 22 2024, 5:23 PM
Jdlrobson added a project: Design-System-Team.Feb 22 2024, 8:59 PM
Jdlrobson edited projects, added Codex; removed MobileFrontend.

These buttons use Codex CSS only buttons. Wouldn't it be better to fix these upstream? (Haven't looked into detail to exactly what is happening here but given the latest Codex release I think it would be better to get a solution in Codex.

Jdlrobson mentioned this in T358377: Replace MobileFrontend's mf-block with something supported by Codex.Feb 23 2024, 7:40 PM
gerritbot added a comment.Feb 23 2024, 7:58 PM

Change 1005804 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Tweak vertical alignment of "block" buttons

https://gerrit.wikimedia.org/r/1005804

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 23 2024, 8:00 PM
Jdlrobson closed this task as Resolved.Feb 23 2024, 8:13 PM
Jdlrobson claimed this task.

I reviewed and merged Ed's patch and opened T358377 for finding a more stable and supported approach to doing this. Thanks for the patch Ed!

Maintenance_bot removed a project: Patch-For-Review.Feb 23 2024, 8:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits