Page MenuHomePhabricator

Unsuppress Phan issues MediaWikiNoBaseException and MediaWikiNoEmptyIfDefined in Wikibase
Closed, ResolvedPublic

Description

In build: Updating mediawiki/mediawiki-phan-config to 0.14.0, two Phan issue types were temporarily suppressed. We should actually fix our code according to the coding conventions (linked below) and remove these suppressions.

  • MediaWikiNoBaseException: Don’t throw \Exception; see exception handling.
  • MediaWikiNoEmptyIfDefined: Don’t use empty() on variables that are always set; see empty().

Event Timeline

Change 1007981 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] client: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1007981

Change 1007981 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] client: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1007981

Change 1008527 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] lib/view: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008527

Change 1008527 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] lib/view: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008527

Change 1008949 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] repo: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008949

Change 1008949 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] repo: Replace empty() with truthy/falsy checks

https://gerrit.wikimedia.org/r/1008949

Change 1009318 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Replace empty() with strict compares to '', 0 or null

https://gerrit.wikimedia.org/r/1009318

Change 1009318 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Replace empty() with strict compares to '', 0 or null

https://gerrit.wikimedia.org/r/1009318

Change 1009797 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] Use RuntimeException/LogicException instead of Exception

https://gerrit.wikimedia.org/r/1009797

Change 1009797 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Use RuntimeException/LogicException instead of Exception

https://gerrit.wikimedia.org/r/1009797

Umherirrender claimed this task.
Umherirrender updated the task description. (Show Details)