Page MenuHomePhabricator

TalkBelow module is failing on Vector's PerformanceBudgetTest
Closed, ResolvedPublic

Description

TalkBelow adds a module to every page, but this is tripping up one of Vector's tests:

10:27:14 2) MediaWiki\Skins\Vector\Tests\Structure\PerformanceBudgetTest::testTotalModulesSize with data set "vector" ('vector', array('80KB', '17KB'))
10:27:14 T346813: Performance budget for styles in skin vector on main article namespace has been exceeded. Total size of styles modules is 17.4 Kbs is greater than the current budget size of 17 Kbs (see Vector/bundlesize.config.json).
10:27:14 Please reduce styles that you are loading on page load or talk to the skin maintainer about modifying the budget.
10:27:14 The following modules are enabled on page load:
10:27:14 skins.vector.styles.legacy
10:27:14 oojs-ui-core.styles
10:27:14 oojs-ui.styles.indicators
10:27:14 mediawiki.widgets.styles
10:27:14 oojs-ui-core.icons
10:27:14 site.styles
10:27:14 noscript
10:27:14 user.styles
10:27:14 Failed asserting that 17805 is equal to 17408.0 or is less than 17408.0.
10:27:14 
10:27:14 /workspace/src/skins/Vector/tests/phpunit/structure/PerformanceBudgetTest.php:154

The ext.TalkBelow module is not actually listed there for some reason.

It seems that the actual bug here is that Vector (or WMF CI) is enforcing a performance budget on an extension that is not used within Wikimedia. Is there a config somewhere that controls this?

Details

Event Timeline

Change 1006155 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/extensions/TalkBelow@master] Enable OOUI in earlier hook

https://gerrit.wikimedia.org/r/1006155

Strangely enough, TalkBelow doesn't even have a stylesheet.

Strangely enough, TalkBelow doesn't even have a stylesheet.

It appears to be loading OOUI on page load though for articles - which is a considerable amount of CSS/JS and likely to cause your users performance problems. Have you considered using Codex instead? That should already be loaded on the article namespace.

Change 1006155 merged by jenkins-bot:

[mediawiki/extensions/TalkBelow@master] Use MWUI for the no-JS button

https://gerrit.wikimedia.org/r/1006155

(this should have already been resolved - the budget test flagged a legitimate issue with https://gerrit.wikimedia.org/r/1006155 that was since fixed)