Page MenuHomePhabricator

MinervaNeue: Assign a default background color for tables using "wikitable" class
Closed, ResolvedPublic

Description

Currently, the styles for "wikitable" class does not specify a background color.

Someone might customize their wiki by changing the background color. In current behavior, it might make tables harder to distinguish since the table background color is inherited from page background color.

An extreme example as following:

image.png (389×1 px, 22 KB)

Obviously, the 2 normal table cells are hard to distinguish its contents.

Then, by assign a default background color to "wikitable" class, it is more distinguishable, as following:

image.png (389×1 px, 22 KB)

The new table background will use the same color (the variable --background-color-base) as the page background, which will not change the look in default installations.

Event Timeline

Change 1006169 had a related patch set uploaded (by Anterdc99; author: Anterdc99):

[mediawiki/skins/MinervaNeue@master] Assign a default background color for tables using "wikitable" class

https://gerrit.wikimedia.org/r/1006169

Anterdc99 renamed this task from MinervaNeue: Assign a default background color for tables using "wikitable" class to Assign a default background color for tables using "wikitable" class.Feb 25 2024, 7:37 PM
Anterdc99 renamed this task from Assign a default background color for tables using "wikitable" class to MinervaNeue: Assign a default background color for tables using "wikitable" class.

In Minerva the backgrounds are currently transparent and in Vector they are #f8f9fa. In T334790 we plan to standardize the background colors so it might make sense to hold off of any changes before that ticket is completed. On the long run I think we should look to get Minerva using the styles defined here https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawiki.skinning/content.tables.less#L9

Given nothing is currently broken per-se (some might say this is a feature and it's easily worked around) I think we should at least hold off on changing anything here until T334790.

Change 1006169 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Assign a default background color for tables using "wikitable" class

https://gerrit.wikimedia.org/r/1006169

Jdlrobson claimed this task.

Thanks for the task and code contribution!