Page MenuHomePhabricator
Create Task
Maniphest T358498

Change line height on Minerva to 1.65 for "Standard" font size
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To
ovasileva
Authored By
JScherer-WMF
Feb 26 2024, 4:13 PM
Tags
Referenced Files
F42274483: screenshot 598.png
Mar 1 2024, 3:22 AM
F42274479: screenshot 597.png
Mar 1 2024, 3:22 AM
F42274476: screenshot 596.png
Mar 1 2024, 3:22 AM
F42257564: screenshot 594.png
Feb 29 2024, 5:28 PM
F42257619: screenshot 595.png
Feb 29 2024, 5:28 PM
F42257558: screenshot 593.png
Feb 29 2024, 5:28 PM
F42257150: screenshot 592.png
Feb 29 2024, 5:11 PM
F42257145: screenshot 591.png
Feb 29 2024, 5:11 PM
View All 9 Files
Subscribers
Aklapper
Edtadros
Jdlrobson
JScherer-WMF
Masumrezarock100
UOzurumba

Description

Following the outcome of T357770:

Acceptance criteria

  • Change the line-height: 1.5; rule in resources/mobile.init.styles/mobile.less so it only applies to regular and large mode

QA

  • Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65
  • Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
  • Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5

QA Results - Beta

ACStatusDetails
1✅T358498#9588069
2✅T358498#9588069
3✅T358498#9588069

QA Results - Prod

ACStatusDetails
1✅T358498#9589618
2✅T358498#9589618
3✅T358498#9589618

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert line height in "Standard" mode, apply to all content in othermediawiki/extensions/MobileFrontendmaster+8 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

JScherer-WMF created this task.Feb 26 2024, 4:13 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptFeb 26 2024, 4:13 PM
Jdlrobson updated the task description. (Show Details)Feb 26 2024, 5:25 PM
Jdlrobson renamed this task from Change line height on Minerva to 1.65em to Change line height on Minerva to 1.65.Feb 26 2024, 5:49 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson renamed this task from Change line height on Minerva to 1.65 to Change line height on Minerva to 1.65 for "Standard" font size.Feb 26 2024, 6:26 PM
ovasileva triaged this task as High priority.Feb 26 2024, 6:26 PM
ovasileva added a project: User-notice.Feb 26 2024, 6:29 PM
ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.
ovasileva set the point value for this task to 1.
Jdlrobson moved this task from Incoming to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.Feb 26 2024, 6:32 PM
Jdlrobson mentioned this in T357983: Mobile font size and line-height changes only applied to <p> elements.Feb 26 2024, 6:41 PM
Jdlrobson claimed this task.Feb 26 2024, 8:09 PM
Jdlrobson moved this task from Ready for Development to Doing on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.
gerritbot added a comment.Feb 26 2024, 8:14 PM

Change 1006580 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/MobileFrontend@master] Revert line height in "Standard" mode, apply to all content in other

https://gerrit.wikimedia.org/r/1006580

gerritbot added a project: Patch-For-Review.Feb 26 2024, 8:14 PM
Jdlrobson moved this task from Doing to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.Feb 26 2024, 8:14 PM
gerritbot added a comment.Feb 26 2024, 9:47 PM

Change 1006580 merged by jenkins-bot:

[mediawiki/extensions/MobileFrontend@master] Revert line height in "Standard" mode, apply to all content in other

https://gerrit.wikimedia.org/r/1006580

Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.Feb 26 2024, 10:03 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 26 2024, 10:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.20; 2024-02-27).Feb 27 2024, 1:01 AM
ovasileva added a parent task: T357770: Evaluate rationale for line height changes in Minerva.Feb 27 2024, 9:39 AM
Jdlrobson reassigned this task from Jdlrobson to Edtadros.Feb 27 2024, 5:40 PM
Jdlrobson moved this task from QA to Code Review on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.
Jdlrobson moved this task from Code Review to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.
Jdlrobson subscribed.
Jdlrobson updated the task description. (Show Details)Feb 29 2024, 1:49 AM
Edtadros removed Edtadros as the assignee of this task.Feb 29 2024, 5:11 PM
Edtadros moved this task from QA to Needs More Work on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.
Edtadros subscribed.

Test Result - Beta

Status: ❌
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65

screenshot 590.png (923×1 px, 463 KB)

❌ AC2: Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
it shows 1.4
screenshot 591.png (923×1 px, 472 KB)

❌ AC3: Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5
it shows 1.4
screenshot 592.png (923×1 px, 470 KB)

Edtadros updated the task description. (Show Details)Feb 29 2024, 5:12 PM
Jdlrobson assigned this task to Edtadros.Feb 29 2024, 5:19 PM

@Edtadros please check the line height on #bodyContent element instead.

Jdlrobson moved this task from Needs More Work to QA on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.Feb 29 2024, 5:19 PM
Edtadros removed Edtadros as the assignee of this task.Feb 29 2024, 5:28 PM
Edtadros moved this task from QA to Ready for Signoff on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 4) board.

Thanks @Jdlrobson

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65

screenshot 593.png (1×1 px, 728 KB)

✅ AC2: Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 595.png (1×1 px, 733 KB)

✅ AC3: Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 594.png (1×1 px, 729 KB)

Edtadros updated the task description. (Show Details)Feb 29 2024, 5:31 PM
UOzurumba subscribed.Feb 29 2024, 7:00 PM

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

Jdlrobson assigned this task to ovasileva.Feb 29 2024, 11:10 PM
UOzurumba moved this task from To Triage to Not ready to announce on the User-notice board.Mar 1 2024, 1:17 AM
Edtadros added a comment.Mar 1 2024, 3:09 AM
In T358498#9588539, @UOzurumba wrote:

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

@UOzurumba , I'm not sure I understand the context or the question. Ping me on slack to discuss.

Edtadros added a comment.Mar 1 2024, 3:22 AM

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

✅ AC1: Choose the standard font size in the settings. Check line height of paragraphs - it should be 1.65

screenshot 596.png (979×1 px, 398 KB)

✅ AC2: Choose the medium font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 597.png (989×1 px, 337 KB)

✅ AC3: Choose the large font size in the settings. Check line height of paragraphs - it should be 1.5
screenshot 598.png (862×1 px, 267 KB)

Edtadros updated the task description. (Show Details)Mar 1 2024, 3:24 AM
ovasileva mentioned this in T357770: Evaluate rationale for line height changes in Minerva.Mar 1 2024, 12:00 PM
Edtadros added a project: Verified.Mar 2 2024, 1:26 AM
ovasileva added a comment.Mar 4 2024, 9:41 AM
In T358498#9588539, @UOzurumba wrote:

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

@UOzurumba - I would suggest: "After consulting with various communities, the line height of the text on the Minerva skin will be increased to its previous value of 1.65. Different options for typography can also be set using the options in the menu, as needed."

Edtadros mentioned this in T358383: Verify 1.42.0-wmf.20 deployment.Mar 5 2024, 2:52 PM
UOzurumba moved this task from Not ready to announce to In current Tech/News draft on the User-notice board.Mar 7 2024, 7:22 PM
UOzurumba added a comment.Mar 7 2024, 9:39 PM
In T358498#9595145, @ovasileva wrote:
In T358498#9588539, @UOzurumba wrote:

Hello @Edtadros,
For Tech News - What wording would you suggest as the content, and When should it be included? Thanks!

@UOzurumba - I would suggest: "After consulting with various communities, the line height of the text on the Minerva skin will be increased to its previous value of 1.65. Different options for typography can also be set using the options in the menu, as needed."

Thanks!

Jdlrobson moved this task from Backlog to Font Size on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:11 AM
ovasileva closed this task as Resolved.Mar 8 2024, 2:03 PM
UOzurumba moved this task from In current Tech/News draft to Already announced/Archive on the User-notice board.Mar 14 2024, 8:49 PM
Maintenance_bot edited projects, added User-notice-archive; removed User-notice.Mar 24 2024, 9:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits