Page MenuHomePhabricator

Phonos is not night mode friendly
Closed, ResolvedPublic0 Estimated Story PointsBUG REPORT


Steps to replicate the issue (include links if applicable):

Other pages with the problem:

What happens?:

Screenshot 2024-02-27 at 11.17.23 AM.png (726×1 px, 130 KB)

  • Icon is black
  • Link is unreadable

What should have happened instead?:

  • There is a rule .oo-ui-buttonElement-frameless.oo-ui-widget-enabled > .oo-ui-buttonElement-button { color: #202122;}

This should be using a Codex design token

  • The skin-invert class can be added to the associated icons

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

QA Results - Prod


Event Timeline

Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald Transcript
Jdlrobson updated the task description. (Show Details)

The issue here is the OOUI button. The long term fix here would be to use Codex.

Change 1009623 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Phonos@master] Short term fix for phonos button

Change 1009623 merged by jenkins-bot:

[mediawiki/extensions/Phonos@master] Short term fix for phonos button

Jdlrobson updated the task description. (Show Details)
Jdlrobson set the point value for this task to 0.
Jdlrobson moved this task from Incoming to QA on the Web-Team-Backlog (FY2023-24 Q3 Sprint 5) board.
Jdlrobson lowered the priority of this task from High to Medium.Mar 18 2024, 5:15 PM
Edtadros subscribed.

Test Result - Prod

Status: ✅ PASS
Environment: enwiki
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device:NA

Test Artifact(s):

QA Steps

Visit or
With the WCAG color contrast checker enabled there are color contrast issues with Phonos

✅ AC1: Icon is not black and has no WCAG Color Contrast issues
✅ AC2: Link is unreadable and has no WCAG Color Contrast issues

screenshot 97.png (682×1 px, 287 KB)