Page MenuHomePhabricator

Event registration can get associated with pages outside the event namespace upon page move
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Create an event page and enable registration
  • Move the event page; you can leave the title as-is, but choose a namespace other than "Event"

What happens?:
The move goes through. If you go to the new page, the registration header isn't shown; however, you can verify in the database that the registration has indeed been associated with the non-Event page.

Further, if you move the page back to the Event namespace (leaving a redirect behind), the move will go through but the registration will remain associated with the non-Event page (i.e., it's not moved automatically).

What should have happened instead?:
Good question. Since we chose to not allow event registration to be enabled on page outside of the Event namespace, I think we should disallow moving a page to outside the namespace if it has a registration associated.

If we choose to do T318179 (allow enabling registration outside the Event namespace), then I think we should just remove this limitation, and make sure that the registration header shows as normal regardless of the namespace.

Software version (skip for WMF-hosted wikis like Wikipedia): master

Other information (browser name/version, screenshots, etc.): ∅

Event Timeline

Change 1007419 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Disallow moving event pages outside of the Event namespace

https://gerrit.wikimedia.org/r/1007419

Change 1007419 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Disallow moving event pages outside of the Event namespace

https://gerrit.wikimedia.org/r/1007419

vaughnwalters subscribed.

✅ disallow moving a page to outside the namespace if it has a registration associated

Screenshot 2024-03-11 at 2.53.37 PM.png (1×2 px, 335 KB)


Also, it can not be moved to a page outside the namespace if it had a registration attached but that registration was then deleted.

Screenshot 2024-03-11 at 3.08.56 PM.png (1×2 px, 377 KB)


Also, If an event is moved out of the Event namespace, and into another namespace before it has had registration enabled, it can then also be successfully moved back to the event namespace.

moving this to product sign off