Page MenuHomePhabricator

Re-evaluate data cache security issues, along with per user data caching
Closed, DeclinedPublic

Description

In previous superset versions, DATA_CACHE_CONFIG was deemed a security issue, because a user without read rights on the original data would we allowed to see the cached data.

Let's re-evaluate this to see whether this is still the case in Superset 3.0.

Event Timeline

Change 1007580 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] superset: allow usage of DATA_CACHE_STORAGE

https://gerrit.wikimedia.org/r/1007580

Change 1007581 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] superset-next: enable data cache

https://gerrit.wikimedia.org/r/1007581

Change 1007582 had a related patch set uploaded (by Brouberol; author: Brouberol):

[operations/deployment-charts@master] superset-next: enable per-user query cache

https://gerrit.wikimedia.org/r/1007582

brouberol renamed this task from Re-evaluate data cache security issues, along with per user data cachin to Re-evaluate data cache security issues, along with per user data caching.Feb 29 2024, 11:30 AM
brouberol updated the task description. (Show Details)

Change 1007580 merged by Brouberol:

[operations/deployment-charts@master] superset: allow usage of DATA_CACHE_CONFIG

https://gerrit.wikimedia.org/r/1007580

Change 1007581 merged by Brouberol:

[operations/deployment-charts@master] superset-next: enable data cache

https://gerrit.wikimedia.org/r/1007581

I think that this can be merged with (or into?) {T273850}

That was the original ticket where we attempted to enable caching, but then rolled back due to the security concerns.

Agreed, let's merge.

Change 1007582 merged by Brouberol:

[operations/deployment-charts@master] superset-next: enable per-user query cache

https://gerrit.wikimedia.org/r/1007582