Page MenuHomePhabricator
Create Task
Maniphest T358893

For consideration: Spacing between code blocks and paragraph seems a little big
Closed, DuplicatePublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:
Large margin between paragraph and code block

Screenshot 2024-03-01 at 10.26.38 AM.png (510×1 px, 67 KB)

What should have happened instead?:
Perhaps ?

Screenshot 2024-03-01 at 10.27.08 AM.png (592×1 px, 82 KB)

(It seems there is a margin-top on pre elements that increases the space here which comes from the user default stylesheet). This could be a good rule to add to our normalize stylesheet? cc @Volker_E

This also impacts blockquote elements (see original bug report in T358921)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Mar 1 2024, 6:28 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 1 2024, 6:28 PM
Jdlrobson mentioned this in T352875: Lists and other line breaking items appearing within paragraphs have the wrong vertical margins. .Mar 1 2024, 6:29 PM
Jack_who_built_the_house subscribed.Mar 1 2024, 11:31 PM
Jack_who_built_the_house added a comment.EditedMar 1 2024, 11:34 PM

It was 1em margin originally, now it's 1em margin + 0.5em padding of p due to T352875. Since p now has padding instead of margin on the bottom, margins don't collapse.

Jdlrobson awarded a token.Mar 1 2024, 11:55 PM
Jack_who_built_the_house mentioned this in T358921: Excessive space after p tags is causing new spacing issues.Mar 3 2024, 7:44 PM
Jdlrobson added a project: Vector 2022.Mar 7 2024, 12:19 AM
Jdlrobson updated the task description. (Show Details)
Jdlrobson merged a task: T358921: Excessive space after p tags is causing new spacing issues.
Jdlrobson added a subscriber: Jonesey95.
Jonesey95 added a comment.Mar 7 2024, 1:10 AM

Task T358921 was closed as a duplicate of this one. Please ensure that any test cases related to fixing this problem include the multiple situations described in that bug report.

Jdlrobson added a comment.Mar 7 2024, 1:26 AM
In T358893#9609757, @Jonesey95 wrote:

Task T358921 was closed as a duplicate of this one. Please ensure that any test cases related to fixing this problem include the multiple situations described in that bug report.

Yes it's mentioned in the description. https://phabricator.wikimedia.org/T358893#9609722

That said T358921 doesn't provide clear reproduction steps that a QA engineer would necessarily understand. If you want to provide specific test cases in the same format of the description we will make sure to test them. For visual changes screenshots like the one in this description are very helpful in reducing misunderstanding.

ovasileva assigned this task to JScherer-WMF.Mar 7 2024, 6:10 PM
ovasileva triaged this task as Medium priority.
ovasileva added a project: FY2023-24-WE 2.1 Typography and palette customizations.
ovasileva added a parent task: T313828: [EPIC] Typography: improve typography and allow for variable typography settings .
ovasileva set the point value for this task to 2.Mar 7 2024, 6:13 PM
Jdlrobson moved this task from Backlog to Font Size on the FY2023-24-WE 2.1 Typography and palette customizations board.Mar 8 2024, 12:11 AM
Jdlrobson moved this task from Incoming to Design Review on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.Mar 8 2024, 5:47 PM
Jdlrobson moved this task from Design Review to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.Mar 11 2024, 5:25 PM
ovasileva removed the point value 2 for this task.Mar 11 2024, 5:31 PM
Jdlrobson moved this task from Ready for Development to Design Review on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.Mar 11 2024, 9:37 PM
Jdlrobson moved this task from Design Review to Ready for Development on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.
JScherer-WMF removed JScherer-WMF as the assignee of this task.Mar 18 2024, 4:48 PM
JScherer-WMF raised the priority of this task from Medium to Needs Triage.
JScherer-WMF moved this task from Ready for Development to Incoming on the Web-Team-Backlog-Archived (FY2023-24 Q3 Sprint 5) board.
JScherer-WMF added subscribers: bwang, ovasileva, JScherer-WMF.

Confirmed that this is a bug. This looks like the inverse of T358808.

@bwang @Jdlrobson there are several little bugs like this relating to vertical spacing. Let's discuss how we can get ahead of any more than might crop up.

Moving back to incoming so @ovasileva can triage the bug fix, and putting it up for grabs.

JScherer-WMF mentioned this in T357084: H3s on Minerva have too much vertical space above them.Mar 18 2024, 4:52 PM
Jdlrobson assigned this task to JScherer-WMF.Mar 19 2024, 5:00 PM

Justin to create a new ticket with a revised design spec of how the text should behave.

JScherer-WMF mentioned this in T360917: [Spike 3hrs] Unintended vertical spacing behaviour .Mar 25 2024, 4:33 PM
JScherer-WMF closed this task as a duplicate of T360917: [Spike 3hrs] Unintended vertical spacing behaviour .Mar 25 2024, 4:35 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits