⚓ T358950 Local interlanguage links don’t work with Parsoid read views

Subject	Repo	Branch	Lines +/-
Deduplicate language links in ParserOutput and OutputPage	mediawiki/core	master	+115 -55
Bump wikimedia/parsoid to 0.20.0-a19	mediawiki/vendor	master	+70 -70
Bump wikimedia/parsoid to 0.20.0-a19	mediawiki/vendor	master	+70 -70
Add local interlanguage links to page metadata	mediawiki/services/parsoid	master	+18 -11

Status	Subtype	Assigned	Task
Open	Release	None	T84936 Release VisualEditor-MediaWiki as "1.0"
Open		None	T50429 [Epic] Support editing parts of a page in VisualEditor-MediaWiki
Open		None	T54365 Explore performance gains from progressive (JIT?) de-alienation in VisualEditor
Open		None	T396539 Introduce a way to edit a span of text from within read mode
Open		None	T385558 Improve copy and paste from read mode to VE
Open		None	T174303 Copy-pasting linked ISBN numbers from view mode HTML into VisualEditor inserts wikitext links to Special:BookSources (it should turn them into magic links?)
Open	Feature	None	T54091 The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces
Open		None	T55784 [EPIC] Use Parsoid HTML for all page views
Open		None	T272987 [EPIC] Parsoid read views for DiscussionTools
Open		None	T297840 Populate ParserCache with Parsoid output as a post-edit hook
Open		None	T393717 Put lints in ParserOutput/RefreshLinksJob
Open	BUG REPORT	None	T393682 Wikifunctions fragments that trigger errors and try to put the page in a tracking category show it at the bottom of the view page, but the pages using the fragment do not appear on the category page
Open		None	T409815 SLI: MediaWiki system load
Open		None	T393716 [EPIC] RefreshLinksJob should use Parsoid-generated metadata
Open		None	T310511 Metadata comparison testing between Parsoid and the legacy parser
Open		None	T310512 Parsoid and the legacy parser should emit exactly the same ParserOutput metadata
Open		None	T331483 Resolve differences between Parsoid & legacy parser TOC metadata output for template, extension, and parser-function generated content
Resolved		cscott	T213468 Parsoid section IDs don't correspond to PHP section IDs when headings are transcluded
Resolved		ABreault-WMF	T215628 Make Parsoid and PHP edit-section numbering consistent when <noinclude> and <includeonly> are in use
Resolved		cscott	T214538 MediaWiki shouldn't assign section numbers during tokenization, but instead only when headings are generated
Open		cscott	T359221 Parsoid's TOC handling needs to deal with HTML-returning components (exts, SPTs, parser funcs returning HTML) consistently
Resolved		ssastry	T359450 Parsoid is not adding headings to TOC entries in some templated content scenarios
Resolved		Jgiannelos	T402456 More Parsoid TOC edge cases?
Open		Jgiannelos	T415554 From TOC difftesting (legacy/parsoid): Differences in template handling from sections
Open		Jgiannelos	T415558 From TOC difftesting (legacy/parsoid): Mismatch when sections come from the same article
Open		Jgiannelos	T415563 From TOC difftesting (legacy/parsoid): Inconsistent index level between legacy and parsoid
Open		Jgiannelos	T415565 From TOC difftesting (legacy/parsoid): Section titles wrapped in html elements on parsoid
Resolved		Jgiannelos	T403188 Implement TOC comparison in Linter extension
Resolved		ihurbain	T371640 [EPIC] Deploy Parsoid Read Views for all Wikivoyage wikis
Resolved	BUG REPORT	Jgiannelos	T358950 Local interlanguage links don’t work with Parsoid read views

Tacsipacsi created this task.Mar 2 2024, 12:03 PM

Restricted Application added a project: Parsoid. · View Herald TranscriptMar 2 2024, 12:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

The simple way to reproduce is using user page: https://en.wikipedia.org/wiki/User:Jimbo_Wales?useparsoid=1 - until we resolved T168792, interlanguage links of user pages are still stored locally.

Similar to T351931, this may just be another case where Parsoid isn't adding these links to metadata?

Note: please make sure local interlanguage link will override those provided by Wikibase amd Cognate.

In T358950#9593315, @ssastry wrote:

Similar to T351931, this may just be another case where Parsoid isn't adding these links to metadata?

The method just below the one touched by the patch for T351931 contains a comment saying

TODO: […] when calling ContentMetadataCollector::addLanguageLink() here (which we should eventualy be doing)

so yeah, that may be the culprit.

MSantos edited projects, added Content-Transform-Team-WIP; removed Content-Transform-Team.Mar 7 2024, 3:26 PM

MSantos moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.

Yeah, it's "just" missing metadata -- I wasn't aware that interlanguage links were actually used in production (I thought they were /replaced/ by wikidata, instead of just /supplementing/ wikidata) so I didn't prioritize this work. But it should be fixed as part of the Parsoid metadata work which @Jgiannelos is doing.

cscott added a parent task: T310512: Parsoid and the legacy parser should emit exactly the same ParserOutput metadata.Mar 7 2024, 3:28 PM

MSantos moved this task from Uncategorized to Phase 1 - DiscussionTools support on the Parsoid-Read-Views board.Apr 11 2024, 2:29 PM

MSantos edited projects, added Parsoid-Read-Views (Phase 1 - DiscussionTools support); removed Parsoid-Read-Views.

ihurbain claimed this task.Apr 29 2024, 9:22 AM

ihurbain removed ihurbain as the assignee of this task.Apr 29 2024, 2:06 PM

ihurbain subscribed.

cscott moved this task from Backlog to Current Deploy Target on the Content-Transform-Team-WIP board.Apr 29 2024, 3:15 PM

MSantos moved this task from Current Deploy Target to In Progress on the Content-Transform-Team-WIP board.Apr 29 2024, 3:21 PM

Jgiannelos claimed this task.Apr 29 2024, 3:22 PM

RheingoldRiver subscribed.May 3 2024, 7:01 PM

Change #1036294 had a related patch set uploaded (by Jgiannelos; author: Jgiannelos):

[mediawiki/services/parsoid@master] Add local interlanguage links to page metadata