Page MenuHomePhabricator

Optimize phan-taint-check speed, 2024 edition
Open, Needs TriagePublic

Description

This task is the same as T203651: Optimize phan-taint-check speed, but 2024 edition. Taint-check received some new features, and the runtime has increased. It's hard to set a specific goal as definition of goal for this task. As of 2024-03-03, it takes 2m 48s to run phan on MW core on my laptop. I'm hoping to decrease that by ~30 seconds if possible.

Event Timeline

Change #1079042 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Fix mutation leak in MethodLinks::normalize

https://gerrit.wikimedia.org/r/1079042

Change #1079650 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Fix method links for values and keys

https://gerrit.wikimedia.org/r/1079650

Change #1079042 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Fix mutation leak in MethodLinks::normalize

https://gerrit.wikimedia.org/r/1079042

Change #1079650 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Fix method links for values and keys

https://gerrit.wikimedia.org/r/1079650

Change #1086572 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Make most remaining objects immutable

https://gerrit.wikimedia.org/r/1086572

Change #1086572 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Make most remaining objects immutable

https://gerrit.wikimedia.org/r/1086572

Change #1152408 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/phan/SecurityCheckPlugin@master] Batch shape updates when visiting arrays

https://gerrit.wikimedia.org/r/1152408

Change #1152408 merged by jenkins-bot:

[mediawiki/tools/phan/SecurityCheckPlugin@master] Batch shape updates when visiting arrays

https://gerrit.wikimedia.org/r/1152408