Page MenuHomePhabricator
Create Task
Maniphest T359006

Rollback and other autogenerated summaries potentially missing from mobile apps
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):
Recently iOS and Android apps started to use hashtags in the edit summaries. While well-intentioned, it seems like this feature also makes the standard edit summaries for regular actions such as rollback not appear from the app edits:

Seems like Android app edits are affected, not sure about iOS. Probably best to check in both.

What should have happened instead?:
Standard edit summaries should be used when appropriate for all actions, even with hashtags.

Related Objects

Event Timeline

stjn created this task.Mar 3 2024, 10:15 PM
Restricted Application added subscribers: Base, Aklapper. · View Herald TranscriptMar 3 2024, 10:15 PM
stjn renamed this task from Rollback and possibly other autogenerated summaries potentially missing from mobile apps to Rollback and other autogenerated summaries potentially missing from mobile apps.Mar 3 2024, 10:15 PM
Dbrant claimed this task.Mar 5 2024, 1:37 PM
Dbrant triaged this task as Medium priority.
Dbrant moved this task from Needs Triage to Android Release - FY2023-24 on the Wikipedia-Android-App-Backlog board.
Dbrant edited projects, added Wikipedia-Android-App-Backlog (Android Release - FY2023-24); removed Wikipedia-Android-App-Backlog.
Dbrant moved this task from Epics in Progress to Code Review on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.
Dbrant subscribed.

Good find! It looks like we were populating the edit summary for rollback edits, while forgetting that this would override the default rollback summary, which contains much useful information.
We will update this to explicitly populate the summary correctly (with the default mediawiki revertpage message) and append our hashtag at the end.

other autogenerated summaries

When you mention "other autogenerated summaries", can you give examples other than rollback summaries that don't seem right?

stjn added a comment.Mar 5 2024, 1:40 PM

I can’t, that’s why I said ‘possibly’. Things to check can be stuff like redirect/page creations, but I can’t know for sure.

Dbrant moved this task from Code Review to Merged and Waiting on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Mar 5 2024, 1:52 PM
SNowick_WMF subscribed.Mar 5 2024, 5:59 PM
cooltey moved this task from Merged and Waiting to QA signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Mar 12 2024, 5:32 PM
HNordeenWMF mentioned this in T359978: Automatic edit summaries for Undo in Edit Patrol.Mar 12 2024, 7:48 PM
HNordeenWMF subscribed.

Separate task. here: T359978 for addressing this same issue with "Undo" in the Edit Patrol suggested edit

ABorbaWMF moved this task from QA signoff to Ready for PM signoff on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Mar 14 2024, 5:53 PM
ABorbaWMF subscribed.

Working for me on 2.7.50476-r-2024-03-12

HNordeenWMF moved this task from Ready for PM signoff to Ready for release on the Wikipedia-Android-App-Backlog (Android Release - FY2023-24) board.Mar 14 2024, 10:16 PM
cooltey closed this task as Resolved.Mar 21 2024, 5:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits