Page MenuHomePhabricator

Enable type conversion always
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The test for "2=2 is true" fails

The debug messages say:

Expected result: { "Z1K1": "Z40", "Z40K1": "Z41" }
Actual result: { "Z1K1": "Z40", "Z40K1": "Z42" }
Execution debug logs: [ "Z6", "K1:", "typeof object", "String() [object Object]", "JSON {\"Z1K1\":{\"Z1K1\":\"Z9\",\"Z9K1\":\"Z13518\"},\"Z13518K1\":\"2\"}", "K2:", "typeof object", "String() [object Object]", "JSON {\"Z1K1\":{\"Z1K1\":\"Z9\",\"Z9K1\":\"Z13518\"},\"Z13518K1\":\"2\"}" ]

This indicates that the converter to code did not run. The converter is here:
https://www.wikifunctions.org/view/en/Z13519

What should have happened instead?:
2=2 should have been true

We should have had a BigInt instead of an object

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Change rECHO100885975825 had a related patch set uploaded (by Cory Massaro; author: Cory Massaro):

[operations/deployment-charts@master] Allow custom type converters in the orchestrator.

https://gerrit.wikimedia.org/r/1008859

Change rECHO100885975825 abandoned by Cory Massaro:

[operations/deployment-charts@master] Allow custom type converters in the orchestrator.

Reason:

not the right approach

https://gerrit.wikimedia.org/r/1008859

Jdforrester-WMF renamed this task from Natural number converter does not seem to take effect to Enable type conversion always.Mar 5 2024, 2:43 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF moved this task from To Triage to To deploy on the Abstract Wikipedia team board.

Change 1008874 had a related patch set uploaded (by Jforrester; author: Jforrester):

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

Change 1008874 merged by jenkins-bot:

[operations/deployment-charts@master] wikifunctions: Upgrade orchestrator from 2024-02-26-150614 to 2024-03-05-140533

https://gerrit.wikimedia.org/r/1008874

Note that Z13530 now fails with the error bigint are forbidden in JSON.stringify.

Note that Z13530 now fails with the error bigint are forbidden in JSON.stringify.

I guess I could just delete that function – or do you think it’s worth keeping?

Jdforrester-WMF triaged this task as High priority.