Page MenuHomePhabricator

Provide test coverage of the HTMLForm library within MediaWiki
Open, Needs TriagePublic

Description

The HTMLForm is a critical library within MediaWiki's page-painting code, but it lacks tests:

https://doc.wikimedia.org/cover/mediawiki-core/includes/htmlform/index.html

We should fix this.

Examples of UBNs for which this would retrospectively be a sustainability follow-up include:

Event Timeline

Change 1009750 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] tests: Add coverage for various trivial HTMLForm methods

https://gerrit.wikimedia.org/r/1009750

Change 1009750 merged by jenkins-bot:

[mediawiki/core@master] tests: Add coverage for various trivial HTMLForm methods

https://gerrit.wikimedia.org/r/1009750

This is not a sustainability follow-up, it's a preceding task.

Change #1017932 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLFormFieldTestCase: Allow for OOUI tests to be run, too

https://gerrit.wikimedia.org/r/1017932

Change #1017933 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLButtonFieldTest: Also test OOUI HTML output

https://gerrit.wikimedia.org/r/1017933

Change #1017936 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLButtonFieldTest: Test regular HTML output

https://gerrit.wikimedia.org/r/1017936

Change #1017932 merged by jenkins-bot:

[mediawiki/core@master] HTMLFormFieldTestCase: Allow for OOUI tests to be run, too

https://gerrit.wikimedia.org/r/1017932

Change #1017933 merged by jenkins-bot:

[mediawiki/core@master] HTMLButtonFieldTest: Also test OOUI HTML output

https://gerrit.wikimedia.org/r/1017933

Change #1017936 merged by jenkins-bot:

[mediawiki/core@master] HTMLButtonFieldTest: Test regular HTML output

https://gerrit.wikimedia.org/r/1017936

Change #1018725 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLButtonFieldTest: Add tests for most remaining features

https://gerrit.wikimedia.org/r/1018725