Page MenuHomePhabricator
Create Task
Maniphest T359166

Provide test coverage of the HTMLForm library within MediaWiki
Open, Needs TriagePublic
Actions

Description

The HTMLForm is a critical library within MediaWiki's page-painting code, but it lacks tests:

https://doc.wikimedia.org/cover/mediawiki-core/includes/htmlform/index.html

We should fix this.

Examples of UBNs for which this would retrospectively be a sustainability follow-up include:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
HTMLButtonFieldTest: Add tests for most remaining featuresmediawiki/coremaster+36 -1
HTMLButtonFieldTest: Test regular HTML outputmediawiki/coremaster+56 -0
HTMLButtonFieldTest: Also test OOUI HTML outputmediawiki/coremaster+58 -0
HTMLFormFieldTestCase: Allow for OOUI tests to be run, toomediawiki/coremaster+2 -0
tests: Add coverage for various trivial HTMLForm methodsmediawiki/coremaster+45 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdforrester-WMF created this task.Mar 5 2024, 1:39 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 5 2024, 1:39 PM
gerritbot added a comment.Mar 8 2024, 1:21 PM

Change 1009750 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] tests: Add coverage for various trivial HTMLForm methods

https://gerrit.wikimedia.org/r/1009750

gerritbot added a project: Patch-For-Review.Mar 8 2024, 1:21 PM
gerritbot added a comment.Mar 11 2024, 10:45 PM

Change 1009750 merged by jenkins-bot:

[mediawiki/core@master] tests: Add coverage for various trivial HTMLForm methods

https://gerrit.wikimedia.org/r/1009750

Maintenance_bot removed a project: Patch-For-Review.Mar 11 2024, 11:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 12 2024, 1:00 AM
Catrope mentioned this in T360717: HTMLForm hidden fields gone -- CAPTCHA failure rate at 100%.Mar 23 2024, 10:03 PM
Ladsgroup awarded a token.Mar 24 2024, 12:19 AM
Ladsgroup subscribed.
Peachey88 added a project: Sustainability (Incident Followup).Mar 24 2024, 1:17 AM
Peachey88 updated the task description. (Show Details)
Jdforrester-WMF updated the task description. (Show Details)Mar 25 2024, 12:14 PM

This is not a sustainability follow-up, it's a preceding task.

gerritbot added a comment.Apr 8 2024, 8:17 PM

Change #1017932 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLFormFieldTestCase: Allow for OOUI tests to be run, too

https://gerrit.wikimedia.org/r/1017932

gerritbot added a project: Patch-For-Review.Apr 8 2024, 8:17 PM

Change #1017933 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLButtonFieldTest: Also test OOUI HTML output

https://gerrit.wikimedia.org/r/1017933

gerritbot added a comment.Apr 8 2024, 8:43 PM

Change #1017936 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLButtonFieldTest: Test regular HTML output

https://gerrit.wikimedia.org/r/1017936

gerritbot added a comment.Apr 9 2024, 2:16 AM

Change #1017932 merged by jenkins-bot:

[mediawiki/core@master] HTMLFormFieldTestCase: Allow for OOUI tests to be run, too

https://gerrit.wikimedia.org/r/1017932

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.1; 2024-04-16).Apr 9 2024, 3:00 AM
gerritbot added a comment.Apr 10 2024, 12:38 AM

Change #1017933 merged by jenkins-bot:

[mediawiki/core@master] HTMLButtonFieldTest: Also test OOUI HTML output

https://gerrit.wikimedia.org/r/1017933

gerritbot added a comment.Apr 10 2024, 12:38 AM

Change #1017936 merged by jenkins-bot:

[mediawiki/core@master] HTMLButtonFieldTest: Test regular HTML output

https://gerrit.wikimedia.org/r/1017936

gerritbot added a comment.Apr 10 2024, 2:12 PM

Change #1018725 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] HTMLButtonFieldTest: Add tests for most remaining features

https://gerrit.wikimedia.org/r/1018725

Krinkle removed a project: MediaWiki-Core-Tests.Apr 22 2024, 9:04 PM
gerritbot added a comment.Mon, Mar 30, 1:20 PM

Change #1018725 abandoned by Hashar:

[mediawiki/core@master] HTMLButtonFieldTest: Add tests for most remaining features

https://gerrit.wikimedia.org/r/1018725

Maintenance_bot removed a project: Patch-For-Review.Mon, Mar 30, 1:36 PM
gerritbot added a comment.Mon, Mar 30, 11:11 PM

Change #1018725 restored by Thcipriani:

[mediawiki/core@master] HTMLButtonFieldTest: Add tests for most remaining features

https://gerrit.wikimedia.org/r/1018725

gerritbot added a project: Patch-For-Review.Mon, Mar 30, 11:11 PM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Tue, Mar 31, 2:11 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits