Page MenuHomePhabricator

Deployment Ticket - Linting Rule for Template Style Fixes
Closed, ResolvedPublic1 Estimated Story Points

Description

Per T358238, we are adding a new lint rule to the Parsoid extension. This lint rule will address the issue of defining background colors without corresponding text colors, which has been identified as an antipattern.
This is the deployment ticket to track this and follow up work.

Success Criteria

Related Objects

StatusSubtypeAssignedTask
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
ResolvedJdlrobson
Resolvedovasileva
Resolvedovasileva
ResolvedJScherer-WMF
Resolvedovasileva
ResolvedSpikeSToyofuku-WMF
Resolvedovasileva
ResolvedJdrewniak
ResolvedJScherer-WMF
Resolvedovasileva
ResolvedJdlrobson
Resolvedovasileva
ResolvedVolker_E
ResolvedJdlrobson
ResolvedJdlrobson
DeclinedJdlrobson
ResolvedSToyofuku-WMF
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
ResolvedFeatureNone
OpenNone
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
Resolvedovasileva
ResolvedJdlrobson
ResolvedJdlrobson
ResolvedNone

Event Timeline

Jdlrobson renamed this task from Deployment Ticket - Implement Linting Rule for Template Style Fixes to Deployment Ticket - Linting Rule for Template Style Fixes.Mar 7 2024, 5:54 PM
Jdlrobson updated the task description. (Show Details)

Change 1007448 had a related patch set uploaded (by Jdlrobson; author: Kimberly Sarabia):

[mediawiki/extensions/Linter@master] Add inline background color

https://gerrit.wikimedia.org/r/1007448

Change 1007448 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Add inline background color

https://gerrit.wikimedia.org/r/1007448

Jdlrobson updated the task description. (Show Details)

Change 1012781 had a related patch set uploaded (by Zabe; author: Kimberly Sarabia):

[mediawiki/extensions/Linter@wmf/1.42.0-wmf.22] Add inline background color

https://gerrit.wikimedia.org/r/1012781

Change 1012781 merged by jenkins-bot:

[mediawiki/extensions/Linter@wmf/1.42.0-wmf.22] Add inline background color

https://gerrit.wikimedia.org/r/1012781

Mentioned in SAL (#wikimedia-operations) [2024-03-20T20:20:01Z] <catrope@deploy2002> Started scap: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]]

Mentioned in SAL (#wikimedia-operations) [2024-03-20T20:45:34Z] <catrope@deploy2002> catrope and zabe: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-03-20T21:02:59Z] <catrope@deploy2002> Finished scap: Backport for [[gerrit:1012781|Add inline background color (T359205 T360565)]] (duration: 42m 57s)

This task is causing an issue; see here. Please roll back deployment until you have addressed stuff like this.

This task is causing an issue; see here. Please roll back deployment until you have addressed stuff like this.

This has since been addressed as part of T360796.