Page MenuHomePhabricator
Create Task
Maniphest T359246

[GRAFMIGR] Migrate MediaWiki.wikibase.quality.constraints.* to statslib
Open, Needs TriagePublic
Actions

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

LoggingHelper.php and LoggingHelperTest.php
  • MediaWiki.wikibase.quality.constraints.check.timing.* T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q*_* T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q*_*.count T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q*_*.sum T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.*.sum T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.*.upper T387562
  • MediaWiki.wikibase.quality.constraints.check.entity.timing T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.*_Format*.p95 T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.*_Format*.p99 T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21502404_FormatChecker.p99 T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21503250_TypeChecker.mean T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21503250_TypeChecker.p75 T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21503250_TypeChecker.p95 T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21503250_TypeChecker.upper T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21510865_ValueTypeChecker.mean T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21510865_ValueTypeChecker.p75 T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21510865_ValueTypeChecker.p95 T387562
  • MediaWiki.wikibase.quality.constraints.check.timing.Q21510865_ValueTypeChecker.upper T387562
  • MediaWiki.wikibase.quality.constraints.cache.entity.miss T387562
  • MediaWiki.wikibase.quality.constraints.cache.entity.hit T387562
  • MediaWiki.wikibase.quality.constraints.cache.entity.* T387562
  • MediaWiki.wikibase.quality.constraints.cache.entity.hit.sum T387562
  • MediaWiki.wikibase.quality.constraints.cache.entity.miss.sum T387562
  • MediaWiki.wikibase.quality.constraints.cache.entity.*.sum T387562
  • MediaWiki.wikibase.quality.constraints.check.entity.timing.sum T387562
CheckConstraint*.php
  • MediaWiki.wikibase.quality.constraints.api.checkConstraints.execute T387563
  • MediaWiki.wikibase.quality.constraints.api.checkConstraints.execute.sum T387563
TypeCheckerHelper.php
  • MediaWiki.wikibase.quality.constraints.type.php.success.timing T387564
SpecialConstraintReport.php
  • MediaWiki.wikibase.quality.constraints.specials.specialConstraintReport.executeCheck T387466
  • MediaWiki.wikibase.quality.constraints.specials.specialConstraintReport.executeCheck.sum T387466
SparqlHelper.php and SparqlHelperTest.php
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh.miss T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh.init T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh.hit T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.miss T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.hit T387022
  • MediaWiki.wikibase.quality.constraints.sparql.*throttling T387022
  • MediaWiki.wikibase.quality.constraints.sparql.*throttling.sum T387022
  • MediaWiki.wikibase.quality.constraints.sparql.timing T387022
  • MediaWiki.wikibase.quality.constraints.sparql.timing.count T387022
  • MediaWiki.wikibase.quality.constraints.sparql.timing.median T387022
  • MediaWiki.wikibase.quality.constraints.sparql.cached T387022
  • MediaWiki.wikibase.quality.constraints.sparql.cached.count T387022
  • MediaWiki.wikibase.quality.constraints.sparql.error T387022
  • MediaWiki.wikibase.quality.constraints.sparql.error.http.* T387022
  • MediaWiki.wikibase.quality.constraints.sparql.error.http.*.sum T387022
  • MediaWiki.wikibase.quality.constraints.sparql.error.count T387022
NOTE: Related, but not directly found in the given file - assumption being that this is done in the background of Graphite and now Prometheus:
  • MediaWiki.wikibase.quality.constraints.regex.cache.hit.sum T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.miss.rate T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.miss.sum T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh.hit.sum T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh.init.sum T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh.miss.sum T387022
  • MediaWiki.wikibase.quality.constraints.regex.cache.refresh.sum T387022
Other files
  • MediaWiki.wikibase.quality.constraints.sparql.typeFallback T354909
  • MediaWiki.wikibase.quality.constraints.sparql.typeFallback.count T354909
  • MediaWiki.wikibase.quality.constraints.type.php.overflow.timing T354909
  • MediaWiki.wikibase.quality.constraints.type.php.overflow.timing.median T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.entities.mean T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.entities.median T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.entities.p75 T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.entities.p95 T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.entities.p99 T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.entities.upper T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.timing.count T354909
  • MediaWiki.wikibase.quality.constraints.type.php.success.timing.median T354909
  • MediaWiki.wikibase.quality.constraints.type.sparql.success.timing T354909
  • MediaWiki.wikibase.quality.constraints.type.sparql.success.timing.count T354909
  • MediaWiki.wikibase.quality.constraints.type.sparql.success.timing.median T354909

source code

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Migrate MediaWiki.wikibase.quality.constraints.gadget.* to Prometheusmediawiki/extensions/WikibaseQualityConstraintsmaster+3 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

• lmata created this task.Mar 6 2024, 3:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 3:44 AM
• lmata updated the task description. (Show Details)Mar 6 2024, 3:51 AM
• lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Mar 6 2024, 4:04 AM
colewhite updated the task description. (Show Details)Apr 26 2024, 3:07 PM
colewhite updated the task description. (Show Details)Apr 26 2024, 3:11 PM
colewhite mentioned this in T363584: Hackathon 2024: Stats!.Apr 26 2024, 3:58 PM
ItamarWMDE added a parent task: T371616: [EPIC][GRAFMIGR] Spruce up Wikidata Grafana Metrics.Aug 1 2024, 3:16 PM
MSantos added projects: wmde-wikidata-tech, WMDE Analytics, Wikidata.Aug 15 2024, 5:08 PM
karapayneWMDE renamed this task from Migrate MediaWiki.wikibase.quality.constraints.* to statslib to [GRAFMIGR] Migrate MediaWiki.wikibase.quality.constraints.* to statslib.Aug 29 2024, 8:13 AM
ItamarWMDE moved this task from Incoming to Other Projects on the wmde-wikidata-tech board.Aug 29 2024, 12:49 PM
ItamarWMDE moved this task from Other Projects to Incoming on the wmde-wikidata-tech board.Dec 10 2024, 10:58 AM
ItamarWMDE moved this task from Incoming to Wikidata Omega Triage on the wmde-wikidata-tech board.Dec 10 2024, 1:21 PM
ItamarWMDE edited projects, added wmde-wikidata-tech (Wikidata Omega Triage); removed wmde-wikidata-tech.
ItamarWMDE moved this task from Incoming to Grafana Revamp on the wmde-wikidata-tech (Wikidata Omega Triage) board.
AndrewTavis_WMDE updated the task description. (Show Details)Feb 20 2025, 12:23 PM
AndrewTavis_WMDE updated the task description. (Show Details)
AndrewTavis_WMDE updated the task description. (Show Details)Feb 20 2025, 12:38 PM
AndrewTavis_WMDE mentioned this in T387022: Migrate SparqlHelper.php methods to statslib.Feb 21 2025, 2:01 PM
AndrewTavis_WMDE added a subtask: T387022: Migrate SparqlHelper.php methods to statslib.
AndrewTavis_WMDE updated the task description. (Show Details)Feb 21 2025, 3:02 PM
AndrewTavis_WMDE updated the task description. (Show Details)Feb 24 2025, 9:59 AM
AndrewTavis_WMDE updated the task description. (Show Details)Feb 24 2025, 11:27 AM
AndrewTavis_WMDE updated the task description. (Show Details)
gerritbot added a comment.Feb 26 2025, 10:13 PM

Change #1123038 had a related patch set uploaded (by Andrea Denisse; author: Andrea Denisse):

[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate MediaWiki.wikibase.quality.constraints.gadget.* to Prometheus

https://gerrit.wikimedia.org/r/1123038

gerritbot added a project: Patch-For-Review.Feb 26 2025, 10:13 PM
AndrewTavis_WMDE updated the task description. (Show Details)Feb 27 2025, 2:43 PM
AndrewTavis_WMDE updated the task description. (Show Details)Feb 27 2025, 2:47 PM
AndrewTavis_WMDE updated the task description. (Show Details)
AndrewTavis_WMDE mentioned this in T387466: Migrate SpecialConstraintReport.php methods to statslib.Feb 27 2025, 3:00 PM
AndrewTavis_WMDE updated the task description. (Show Details)Feb 27 2025, 3:54 PM
gerritbot added a comment.Feb 28 2025, 9:46 AM

Change #1123038 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] Migrate MediaWiki.wikibase.quality.constraints.gadget.* to Prometheus

https://gerrit.wikimedia.org/r/1123038

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.19; 2025-03-04).Feb 28 2025, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 28 2025, 10:30 AM
AndrewTavis_WMDE mentioned this in T387562: Migrate LoggingHelper.php methods to statslib.Feb 28 2025, 12:43 PM
AndrewTavis_WMDE added a subtask: T387466: Migrate SpecialConstraintReport.php methods to statslib.
AndrewTavis_WMDE added a subtask: T387562: Migrate LoggingHelper.php methods to statslib.
AndrewTavis_WMDE updated the task description. (Show Details)
AndrewTavis_WMDE mentioned this in T387563: Migrate CheckConstraint.php methods to statslib.Feb 28 2025, 12:53 PM
AndrewTavis_WMDE mentioned this in T387564: Migrate TypeCheckerHelper.php methods to statslib.
AndrewTavis_WMDE added a subtask: T387563: Migrate CheckConstraint.php methods to statslib.
AndrewTavis_WMDE added a subtask: T387564: Migrate TypeCheckerHelper.php methods to statslib.
AndrewTavis_WMDE updated the task description. (Show Details)
AndrewTavis_WMDE updated the task description. (Show Details)
AndrewTavis_WMDE updated the task description. (Show Details)Feb 28 2025, 1:24 PM
AndrewTavis_WMDE updated the task description. (Show Details)Feb 28 2025, 1:30 PM
AndrewTavis_WMDE updated the task description. (Show Details)Feb 28 2025, 1:33 PM
AndrewTavis_WMDE claimed this task.Mar 7 2025, 12:52 PM
AndrewTavis_WMDE moved this task from Incoming to Kanban on the WMDE Analytics board.Mar 7 2025, 1:20 PM
AndrewTavis_WMDE edited projects, added WMDE Analytics (Kanban); removed WMDE Analytics.
AndrewTavis_WMDE moved this task from To-Do (Shortlist) to Internal Review on the WMDE Analytics (Kanban) board.
karapayneWMDE closed subtask T387022: Migrate SparqlHelper.php methods to statslib as Resolved.Mar 18 2025, 4:04 PM
AndrewTavis_WMDE updated the task description. (Show Details)Apr 1 2025, 4:09 PM
karapayneWMDE closed subtask T387564: Migrate TypeCheckerHelper.php methods to statslib as Resolved.Apr 2 2025, 9:24 AM
AndrewTavis_WMDE updated the task description. (Show Details)Apr 2 2025, 9:28 AM
AndrewTavis_WMDE reassigned this task from AndrewTavis_WMDE to • lmata.Apr 2 2025, 9:34 AM
AndrewTavis_WMDE updated the task description. (Show Details)
AndrewTavis_WMDE added subscribers: karapayneWMDE, AndrewTavis_WMDE.
AndrewTavis_WMDE added a subscriber: HasanAkgun_WMDE.Apr 2 2025, 9:42 AM

@lmata, reassigning this task to you for review/confirmation of the work that was done here. There are three open sub-tasks, each of which has a merged patch with changes due to roll out on April 8th's train:

Please let us know if anything else is needed here!

CC @karapayneWMDE whose managing these migrations and @HasanAkgun_WMDE who assisted and reviewed the patches.

colewhite subscribed.Apr 9 2025, 2:45 PM

Hi @AndrewTavis_WMDE!

The final step in the migration is to update the dashboards using these metrics to use the Prometheus metrics provided by the Thanos datasource. I found these dashboards still referencing Graphite for this data:

AndrewTavis_WMDE added a comment.Apr 9 2025, 2:48 PM

Thanks @colewhite! Good point on the Grafana part of all of this. We've been very focused on the Graphite side of things. I'll look into Grafana early next week when I'm back from a vacation. Hopefully we can get this done on Monday :) Saving this message from you at the top of my notifications.

colewhite removed • lmata as the assignee of this task.Apr 9 2025, 8:55 PM
AndrewTavis_WMDE moved this task from Internal Review to In Progress on the WMDE Analytics (Kanban) board.Apr 14 2025, 9:16 AM
karapayneWMDE closed subtask T387466: Migrate SpecialConstraintReport.php methods to statslib as Resolved.Apr 14 2025, 9:24 AM
karapayneWMDE closed subtask T387562: Migrate LoggingHelper.php methods to statslib as Resolved.
AndrewTavis_WMDE added a parent task: T392960: [Analytics] [Request] Migrate all WMDE Grafana dashboards to Prometheus.May 2 2025, 8:41 AM
karapayneWMDE closed subtask T387563: Migrate CheckConstraint.php methods to statslib as Resolved.May 5 2025, 1:22 PM
AndrewTavis_WMDE mentioned this in T392960: [Analytics] [Request] Migrate all WMDE Grafana dashboards to Prometheus.May 7 2025, 2:05 PM
AndrewTavis_WMDE claimed this task.May 22 2025, 10:45 AM
AndrewTavis_WMDE moved this task from In Progress to Ready for Internal Review on the WMDE Analytics (Kanban) board.
karapayneWMDE moved this task from Ready for Internal Review to To-Do (Shortlist) on the WMDE Analytics (Kanban) board.Wed, Apr 22, 2:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits