Page MenuHomePhabricator
Create Task
Maniphest T359382

Migrate MediaWiki.loadbalancer.lag to statslib
Closed, ResolvedPublicSecurity
Actions

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.loadbalancer.lag.*

source code

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
maintenance: getLagTimes migrate to StatsFactoryCwhitemediawiki/coremaster+37 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

• lmata created this task.Mar 6 2024, 2:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 2:25 PM
• lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Mar 6 2024, 2:29 PM
colewhite renamed this task from Migrate MediaWiki.loadbalancer to statslib to Migrate MediaWiki.loadbalancer.lag to statslib.Apr 26 2024, 11:22 PM
colewhite updated the task description. (Show Details)
colewhite mentioned this in T363584: Hackathon 2024: Stats!.
gerritbot added a comment.May 4 2024, 3:27 PM

Change #1026901 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] maintenance: getLagTimes migrate to StatsFactory

https://gerrit.wikimedia.org/r/1026901

gerritbot added a project: Patch-For-Review.May 4 2024, 3:27 PM
colewhite claimed this task.May 4 2024, 3:28 PM
gerritbot added a comment.May 22 2024, 11:59 AM

Change #1026901 merged by jenkins-bot:

[mediawiki/core@master] maintenance: getLagTimes migrate to StatsFactory

https://gerrit.wikimedia.org/r/1026901

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 22 2024, 12:01 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2024, 12:30 PM
colewhite closed this task as Resolved.May 22 2024, 1:58 PM
colewhite set Security to Software security bug.May 31 2024, 3:09 PM
colewhite added projects: Security, Security-Team.
colewhite changed the visibility from "Public (No Login Required)" to "Custom Policy".
colewhite changed the subtype of this task from "Task" to "Security Issue".
colewhite added a comment.May 31 2024, 3:35 PM

I wanted to see what options were available to me when a task became a security issue. This is not a security issue and can have its acls removed. It does not appear that I can do so.

Bawolff changed the visibility from "Custom Policy" to "Public (No Login Required)".May 31 2024, 4:14 PM
RhinosF1 removed projects: Security-Team, Security.May 31 2024, 4:23 PM
Restricted Application added a subscriber: RhinosF1. · View Herald TranscriptMay 31 2024, 4:23 PM
sbassett added a project: SecTeam-Processed.Jun 3 2024, 5:12 PM
Krinkle mentioned this in T370636: Grafana dashboard for RL startup manifest size is not updated since March 2024.Jul 22 2024, 8:49 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits