Page MenuHomePhabricator
Create Task
Maniphest T359403

Wikibase apitests broken in CI: Invalid status: expected 500 to be within 200..299
Closed, ResolvedPublic
Actions

Description

Example test build (change) and gate-and-submit build (change):

  1953 passing (6m)
  58 pending
  26 failing

  1) IP masking
       PATCH /statements/{statement_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  2) IP masking
       PUT /entities/items/{item_id}/labels/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  3) IP masking
       PUT /entities/items/{item_id}/descriptions/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  4) IP masking
       PUT /entities/items/{item_id}/sitelinks/{site_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  5) IP masking
       PATCH /entities/items/{item_id}/sitelinks
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  6) IP masking
       PATCH /entities/items/{item_id}/labels
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  7) IP masking
       PATCH /entities/items/{item_id}/descriptions
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  8) IP masking
       PATCH /entities/items/{item_id}/aliases
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  9) IP masking
       POST /entities/items/{item_id}/aliases/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  10) IP masking
       DELETE /entities/items/{item_id}/labels/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  11) IP masking
       DELETE /entities/items/{item_id}/descriptions/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  12) IP masking
       DELETE /entities/items/{item_id}/sitelinks/{site_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  13) IP masking
       PATCH /entities/properties/{property_id}/labels
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  14) IP masking
       PATCH /entities/properties/{property_id}/descriptions
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  15) IP masking
       PATCH /entities/properties/{property_id}/aliases
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  16) IP masking
       POST /entities/properties/{property_id}/aliases/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  17) IP masking
       POST /entities/properties/{property_id}/statements
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  18) IP masking
       PUT /entities/properties/{property_id}/statements/{statement_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  19) IP masking
       PUT /statements/{statement_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  20) IP masking
       PATCH /entities/properties/{property_id}/statements/{statement_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  21) IP masking
       DELETE /entities/properties/{property_id}/statements/{statement_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  22) IP masking
       DELETE /statements/{statement_id}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  23) IP masking
       PUT /entities/properties/{property_id}/labels/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  24) IP masking
       PUT /entities/properties/{property_id}/descriptions/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  25) IP masking
       DELETE /entities/properties/{property_id}/labels/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

  26) IP masking
       DELETE /entities/properties/{property_id}/descriptions/{language_code}
         makes an edit as a temp user with tempUser enabled:
     AssertionError: 
7Response body: { code: 'unexpected-error', message: 'Unexpected error' }8
Invalid status: expected 500 to be within 200..299
      at Context.<anonymous> (tests/mocha/api-testing/TempUserTest.js:38:36)
      at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

All 26 failing tests are “with tempUser enabled”, and the mw-error.log has acct_creation_throttle_hit errors:

2024-03-06 14:29:02 456d3181d770 wikidb: [551bc48e713e3532f596dace] /rest.php/wikibase/v0/statements/Q113$BDE7E623-C71E-4BA3-8D2E-1A556FDFB9B8   Wikibase\Repo\RestApi\Infrastructure\DataAccess\Exceptions\EntityUpdateFailed: <Error, collected 1 message(s) on the way, array value set>
+----------+---------------------------+--------------------------------------+
| error    | acct_creation_throttle_hi | 6 | [ 86400 ]                        |
|          | t                         |                                      |
+----------+---------------------------+--------------------------------------+

#0 /workspace/src/extensions/Wikibase/repo/rest-api/src/Infrastructure/DataAccess/EntityUpdaterStatementUpdater.php(58): Wikibase\Repo\RestApi\Infrastructure\DataAccess\EntityUpdater->update(Wikibase\DataModel\Entity\Item, Wikibase\Repo\RestApi\Domain\Model\EditMetadata)

So this may be caused by TempUserCreator: Use separate rate limit for temp account creations (T357777).

Unlike T359149, this probably doesn’t affect production.

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
REST: Bump $wgTempAccountCreationThrottle to 100Jakobmediawiki/extensions/Wikibasemaster+4 -0
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 6 2024, 3:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 3:00 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)Mar 6 2024, 3:01 PM
Jakob_WMDE subscribed.Mar 6 2024, 3:02 PM
Michael subscribed.Mar 6 2024, 3:12 PM
gerritbot added a comment.Mar 6 2024, 3:17 PM

Change 1009280 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Bump $wgTempAccountCreationThrottle to 100

https://gerrit.wikimedia.org/r/1009280

gerritbot added a project: Patch-For-Review.Mar 6 2024, 3:17 PM
gerritbot added a comment.Mar 6 2024, 4:09 PM

Change 1009280 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Bump $wgTempAccountCreationThrottle to 100

https://gerrit.wikimedia.org/r/1009280

Maintenance_bot removed a project: Patch-For-Review.Mar 6 2024, 4:30 PM
Jakob_WMDE closed this task as Resolved.Mar 6 2024, 4:31 PM
Jakob_WMDE claimed this task.
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 6 2024, 5:00 PM
Dreamy_Jazz subscribed.Mar 7 2024, 5:23 PM

Thanks for fixing this quickly.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits