Page MenuHomePhabricator
Create Task
Maniphest T359471

Migrate MediaWiki.extension.PageTriage to statslib
Closed, ResolvedPublic
Actions

Description

Follow the migration process as outlined below.

Secure/Conduct code review(s).
Deploy the changes to production via the train (https://wikitech.wikimedia.org/wiki/Deployments/Train).
Verify that the changes have been successfully implemented.
Update the relevant dashboard(s) by replacing the old Graphite metric(s) with the new Prometheus metric(s).
Please follow the guidelines and standards outlined in the provided documentation:

https://www.mediawiki.org/wiki/Manual:Stats for detailed guidance on the conversion process.
https://drive.google.com/file/d/12yQEuOapkML1vb9MgCaX1QzbLBdXE6X2/view for a video tutorial on the conversion process.
https://docs.google.com/presentation/d/1SZWf_D3mWNX-XHN8PHYI84LDZr6GUQC2AMhZ9mQXCI0/edit#slide=id.g2795460c956_0_23 for slides on the best practices for converting metrics to statslib.

  • MediaWiki.extension.PageTriage.by_wiki.enwiki.noindex.sum
  • MediaWiki.extension.PageTriage.by_wiki.*.noindex.rate
  • MediaWiki.extension.PageTriage.enwiki.viewsToolbar.delete.error.sum
  • MediaWiki.extension.PageTriage.enwiki.viewsToolbar.tags.error.sum

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
migrate stats production to Prometheusmediawiki/extensions/PageTriagemaster+26 -26
mediawiki: Add missing counter to the PageTriage metricsmediawiki/extensions/PageTriagemaster+2 -2
mediawiki: Migrate MediaWiki.extension.PageTriage to Prometheusmediawiki/extensions/PageTriagemaster+6 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

• lmata created this task.Mar 6 2024, 8:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 6 2024, 8:56 PM
• lmata mentioned this in T350592: EPIC: migrate in use metrics and dashboards to statslib.Mar 6 2024, 9:08 PM
MPGuy2824 added a project: PageTriage.May 1 2024, 2:05 AM
Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 1 2024, 2:05 AM
MPGuy2824 moved this task from Backlog to Priority technical debt on the PageTriage board.May 1 2024, 2:05 AM
Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.May 17 2024, 10:14 AM
gerritbot added a comment.Feb 26 2025, 9:45 PM

Change #1123035 had a related patch set uploaded (by Andrea Denisse; author: Andrea Denisse):

[mediawiki/extensions/PageTriage@master] mediawiki: Migrate MediaWiki.extension.PageTriage to Prometheus

https://gerrit.wikimedia.org/r/1123035

gerritbot added a project: Patch-For-Review.Feb 26 2025, 9:45 PM
gerritbot added a comment.Mar 5 2025, 10:22 PM

Change #1123035 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] mediawiki: Migrate MediaWiki.extension.PageTriage to Prometheus

https://gerrit.wikimedia.org/r/1123035

Maintenance_bot removed a project: Patch-For-Review.Mar 5 2025, 10:30 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 5 2025, 11:00 PM
andrea.denisse added subscribers: DAlangi_WMF, colewhite, Krinkle, andrea.denisse.EditedMar 27 2025, 8:17 PM

Hi everyone,

I recently migrated this metric, and the change has already been deployed to production. However, I'm unable to find the metric in the Thanos store, which is needed to migrate the associated Grafana panels.

Here's the dashboard in question: PageTriage Debugging

Unlike other Mw.Track metrics, this particular one isn't showing up when selecting Thanos as the data source.

Could you help me understand why this metric might not be appearing in Thanos? @colewhite @Krinkle @DAlangi_WMF Thanks in advance!

gerritbot added a comment.Mar 27 2025, 8:45 PM

Change #1131814 had a related patch set uploaded (by Andrea Denisse; author: Andrea Denisse):

[mediawiki/extensions/PageTriage@master] mediawiki: Add missing counter to the PageTriage metrics

https://gerrit.wikimedia.org/r/1131814

gerritbot added a project: Patch-For-Review.Mar 27 2025, 8:45 PM
colewhite added a comment.Mar 27 2025, 8:48 PM

I think it's because the object is the second argument rather than the measurement.

If so, the cause is that mw.track isn't very ergonomic. It has no function signature, nor any clear tips on what the function expects due to its job is only to queue the data up. We're likely see more of these. Probably worth adding a warning on https://www.mediawiki.org/wiki/ResourceLoader/Core_modules#mw.track if this is truly the problem.

gerritbot added a comment.Mar 27 2025, 10:01 PM

Change #1131814 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] mediawiki: Add missing counter to the PageTriage metrics

https://gerrit.wikimedia.org/r/1131814

Maintenance_bot removed a project: Patch-For-Review.Mar 27 2025, 10:30 PM
andrea.denisse added a comment.Mar 27 2025, 10:38 PM
In T359471#10684764, @colewhite wrote:

I think it's because the object is the second argument rather than the measurement.

If so, the cause is that mw.track isn't very ergonomic. It has no function signature, nor any clear tips on what the function expects due to its job is only to queue the data up. We're likely see more of these. Probably worth adding a warning on https://www.mediawiki.org/wiki/ResourceLoader/Core_modules#mw.track if this is truly the problem.

Once the change is deployed in production I can test if it was issue and I'll add the warning in our docs.
Thanks for taking a look!

andrea.denisse changed the task status from Open to In Progress.Mar 27 2025, 10:38 PM
andrea.denisse claimed this task.
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.23; 2025-04-01); removed MW-1.44-notes (1.44.0-wmf.20; 2025-03-11).Mar 27 2025, 11:00 PM
gerritbot added a comment.Apr 15 2025, 10:38 PM

Change #1136819 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/extensions/PageTriage@master] migrate stats production to Prometheus

https://gerrit.wikimedia.org/r/1136819

gerritbot added a project: Patch-For-Review.Apr 15 2025, 10:38 PM
gerritbot added a comment.Apr 16 2025, 1:21 AM

Change #1136819 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] migrate stats production to Prometheus

https://gerrit.wikimedia.org/r/1136819

Maintenance_bot removed a project: Patch-For-Review.Apr 16 2025, 1:31 AM
ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.27; 2025-04-29); removed MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Apr 16 2025, 2:00 AM
andrea.denisse closed this task as Resolved.Jun 19 2025, 3:28 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits