Page MenuHomePhabricator
Create Task
Maniphest T359537

Special:BotPasswords grant for "access checkuser data" should have the "grants with security risk" icon
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

What happens?:

  • Checkuser has no red triangle icon

image.png (87×1 px, 5 KB)

What should have happened instead?:

  • Checkuser should have a red triangle icon next to it

image.png (90×1 px, 22 KB)

Example of a grant with a red triangle next to it:

image.png (84×1 px, 4 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Move checkuser grant configuration to CheckUser extensionoperations/mediawiki-configmaster+0 -7
Move checkuser grant name to CheckUser extensionmediawiki/extensions/WikimediaMessagesmaster+0 -2
Add grant configurationmediawiki/extensions/CheckUsermaster+23 -0
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Mar 7 2024, 1:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2024, 1:28 PM
Novem_Linguae added a project: MediaWiki-Core-AuthManager.Mar 7 2024, 1:29 PM
Novem_Linguae updated the task description. (Show Details)
Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptMar 7 2024, 1:29 PM
Tgr subscribed.Mar 7 2024, 1:43 PM

It's listed in T290790: Group OAuth grants by riskiness as such but looks like I forgot to make an actual patch for it.

Dreamy_Jazz subscribed.EditedMar 7 2024, 1:46 PM
In T359537#9611392, @Tgr wrote:

It's listed in T290790: Group OAuth grants by riskiness as such but looks like I forgot to make an actual patch for it.

The CheckUser extension does not define GrantPermissions and it is WMF specific configuration that does this. That might explain why it was not done in that ticket. Furthermore, it also suggests that the change is needed in WMF config and not in the CheckUser extension.

Tgr added a comment.Mar 9 2024, 5:08 PM

Those were added in https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/264437 and I'm pretty sure they were meant to be temporary.

gerritbot added a comment.Mar 10 2024, 8:27 AM

Change 1009863 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/CheckUser@master] Add grant configuration

https://gerrit.wikimedia.org/r/1009863

gerritbot added a project: Patch-For-Review.Mar 10 2024, 8:27 AM

Change 1009864 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/WikimediaMessages@master] Move checkuser grant name to CheckUser extension

https://gerrit.wikimedia.org/r/1009864

gerritbot added a comment.Mar 10 2024, 8:31 AM

Change 1009865 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[operations/mediawiki-config@master] Move checkuser grant configuration to CheckUser extension

https://gerrit.wikimedia.org/r/1009865

Tgr claimed this task.Mar 10 2024, 5:43 PM
Tgr moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.
gerritbot added a comment.Mar 11 2024, 4:42 PM

Change 1009863 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Add grant configuration

https://gerrit.wikimedia.org/r/1009863

gerritbot added a comment.Mar 11 2024, 4:42 PM

Change 1009864 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMessages@master] Move checkuser grant name to CheckUser extension

https://gerrit.wikimedia.org/r/1009864

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.22; 2024-03-12).Mar 11 2024, 7:01 PM
gerritbot added a comment.Mar 28 2024, 1:53 PM

Change #1009865 merged by jenkins-bot:

[operations/mediawiki-config@master] Move checkuser grant configuration to CheckUser extension

https://gerrit.wikimedia.org/r/1009865

Stashbot added a comment.Mar 28 2024, 1:54 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:53:57Z] <dreamyjazz@deploy1002> Started scap: Backport for [[gerrit:1009865|Move checkuser grant configuration to CheckUser extension (T359537)]]

Stashbot added a comment.Mar 28 2024, 1:56 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-28T13:56:23Z] <dreamyjazz@deploy1002> tgr and dreamyjazz: Backport for [[gerrit:1009865|Move checkuser grant configuration to CheckUser extension (T359537)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Mar 28 2024, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2024-03-28T14:10:05Z] <dreamyjazz@deploy1002> Finished scap: Backport for [[gerrit:1009865|Move checkuser grant configuration to CheckUser extension (T359537)]] (duration: 16m 08s)

Dreamy_Jazz closed this task as Resolved.Mar 28 2024, 2:12 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 28 2024, 2:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits