CodeMirror 6: Cursor is offset when viewing a mix of LTR/RTL interfaces and page langauge
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	GMikesell-WMF
	Mar 7 2024, 8:23 PM

Description

Steps to replicate the issue (include links if applicable):

Choose any browser (on Ubuntu at least, it may only be an issue with Chrome)
Go to https://en-rtl.wikipedia.beta.wmflabs.org/wiki/I_Started_With_100K?uselang=en
Try to select text, or enter text, etc.

What happens?:

The cursor is offset by roughly 2 characters.

This occurs when:

Interface in LTR and page language in RTL: https://en-rtl.wikipedia.beta.wmflabs.org/wiki/I_Started_With_100K?action=edit&uselang=en
Interface in RTL and page language in LTR: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Dog&action=edit&uselang=en-rtl

What should have happened instead?:
The cursor should be where it is expected and not offset.

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T359589 here

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	CodeMirror: add 'dir' and 'lang' attrs to .cm-editor and not .cm-content	mediawiki/extensions/CodeMirror	master	+27 -13

Customize query in gerrit

Related Objects

Mentioned In: T359611: Search panel should use the same direction as the interface
T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors
Mentioned Here: rMW1db03e070c1e: Merge "docs: Update old mailman references to postorius"
T359611: Search panel should use the same direction as the interface

Event Timeline

GMikesell-WMF created this task.Mar 7 2024, 8:23 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 7 2024, 8:24 PM

GMikesell-WMF mentioned this in T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.Mar 7 2024, 10:48 PM

MusikAnimal renamed this task from CodeMirror6: Bold/Italicize words are not fully captured to CodeMirror 6: Cursor is offset when viewing a mix of LTR/RTL interfaces and page langauge.Mar 7 2024, 11:37 PM

MusikAnimal claimed this task.

MusikAnimal updated the task description. (Show Details)

MusikAnimal moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.

MusikAnimal updated the task description. (Show Details)Mar 7 2024, 11:44 PM

Change 1009631 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):

[mediawiki/extensions/CodeMirror@master] CodeMirror: add 'dir' and 'lang' attrs to .cm-editor and not .cm-content

https://gerrit.wikimedia.org/r/1009631

gerritbot added a project: Patch-For-Review.Mar 8 2024, 1:42 AM

MusikAnimal moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Mar 8 2024, 1:42 AM

One bug fixed, one bug introduced: T359611

Change 1009631 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] CodeMirror: add 'dir' and 'lang' attrs to .cm-editor and not .cm-content

https://gerrit.wikimedia.org/r/1009631

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2024, 12:30 AM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 14 2024, 1:00 AM

MusikAnimal moved this task from Backlog to CodeMirror 6 migration on the MediaWiki-extensions-CodeMirror board.Mar 19 2024, 1:47 AM

MusikAnimal updated the task description. (Show Details)Mar 19 2024, 5:24 PM

MusikAnimal moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.

@MusikAnimal The cursor should be where it is expected and not offset as seen in the videos and screenshots. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.42.0-alpha (1db03e0)
OS: macOS Sonoma 14.4
Browser: Chrome 122, Firefox 123, Safari 17.3, Edge 122
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog#
https://en-rtl.wikipedia.beta.wmflabs.org/w/index.php?title=I_Started_With_100K&action=edit

✅AC1: https://phabricator.wikimedia.org/T359589

Interface in LTR and page language in RTL- Preference	Interface in LTR and page language in RTL- URL	Interface in RTL and page language in LTR

Chrome are the default videos above

Firefox	Safari

Vector 2010	Minerva	Monobook	Timeless

GMikesell-WMF updated the task description. (Show Details)Mar 22 2024, 7:36 PM

GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

MusikAnimal closed this task as Resolved.Mar 22 2024, 7:38 PM

MusikAnimal moved this task from CodeMirror 6 migration to Done on the MediaWiki-extensions-CodeMirror board.

CodeMirror 6: Cursor is offset when viewing a mix of LTR/RTL interfaces and page langaugeClosed, ResolvedPublicBUG REPORTActions