| • MusikAnimal | |
| Mar 8 2024, 8:39 PM |
| F42605942: 2024-03-13_15-13-35.png | |
| Mar 13 2024, 10:14 PM |
| F42605861: 2024-03-13_15-07-25.png | |
| Mar 13 2024, 10:14 PM |
| F42605854: 2024-03-13_15-06-33.png | |
| Mar 13 2024, 10:14 PM |
| F42605851: 2024-03-13_15-05-17.png | |
| Mar 13 2024, 10:14 PM |
| F42605848: 2024-03-13_15-04-05.png | |
| Mar 13 2024, 10:14 PM |
| F42605739: T359671_CM6_Toolbar.webm | |
| Mar 13 2024, 10:14 PM |
This is a follow-up to T211205: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors.
WikiEditor (2010)'s various toolbar functions don't work in CodeMirror 6, such as inserting images, tables, templates, and replace/replace all.
Acceptance criteria
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| CodeMirror: fix implementation of jQuery.textSelection encapsulate | mediawiki/extensions/CodeMirror | master | +239 -76 |
Change 1009826 had a related patch set uploaded (by MusikAnimal; author: MusikAnimal):
[mediawiki/extensions/CodeMirror@master] CodeMirror: fix implementation of jQuery.textSelection encapsulate
Change 1009826 merged by jenkins-bot:
[mediawiki/extensions/CodeMirror@master] CodeMirror: fix implementation of jQuery.textSelection encapsulate
@MusikAnimal WikiEditor toolbar functions do work with CodeMirror 6 as seen in the video below. I did create a separate task T360075: CodeMirror6: WikiEditor toolbar buttons cease to function when CodeMirror toggled on/off more than once of the toolbar not working when you toggle CM6 on/off more than once. As for this task, I will move this to Done. Thanks for all your work!
Status: ✅PASS
Environment: Beta: 1.42.0-alpha (b5d92e4)
OS: macOS Sonoma 14.4
Browser: Chrome 122, Firefox 123, Safari 17.3
Skins. Vector 2022. Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page&action=edit
https://en-rtl.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page&action=edit
✅AC1: https://phabricator.wikimedia.org/T359671
| Vector 2010 | Minerva | Monobook | Timeless | RTL |
 |  |  |  |  |