Page MenuHomePhabricator
Create Task
Maniphest T359806

[jobs-api] Remove flask-restful
Closed, ResolvedPublic
Actions

Description

We don't really use REST, or most of the options flask-restful provides, and it forces us to have our business models mixed with the API models.

Removing the usage of flask-restful will help decouple those, and specially reuse the generated models from the openapi spec whenever we generate the code from it.

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLucasWerkmeisterT320140 Migrate wd-shex-infer from Toolforge GridEngine to Toolforge Kubernetes
 Resolved• matmarexT319707 Migrate dtcheck from Toolforge GridEngine to Toolforge Kubernetes
 ResolvedLegoktmT320062 Migrate steve-adder from Toolforge GridEngine to Toolforge Kubernetes
 ResolvedLegoktmT320011 Migrate rfa-voting-history from Toolforge GridEngine to Toolforge Kubernetes
 In ProgressdcaroT194332 [builds-api,components-api,webservice,jobs-api] Make Toolforge a proper platform as a service with push-to-deploy and build packs
 ResolveddcaroT393564 [Hypothesis] WE6.3.10 start a beta for the push-to-deploy features
 ResolvedkomlaT368600 [KR] WE6.3 Introduce a sustainability scoring system for the Toolforge platform
 ResolveddcaroT375199 [Hypothesis] WE6.3.4 If we enable the automatic deployment of a minimal tool, we will be able to evaluate the end to end flow and set the groundwork for adding support for more complex tools and deployment flows.
 ResolveddcaroT362051 [components-api] First iteration of the component API
 ResolvedRaymond_NdibeT362072 [components-api] Add support for port/healthcheck for continuous jobs in tool config/depolyment
 In ProgressRaymond_NdibeT362077 [components-api] Add webservice support
 OpenNoneT401102 Prebuilt webservice containers should not log to NFS by default
 OpenNoneT311917 [webservice,toolforge-cli] Make `webservice shell` a standalone tool
 In ProgressFeatureRaymond_NdibeT348755 [jobs-api,webservice] Run webservices via the jobs framework
 ResolvedFeatureRaymond_NdibeT348758 [jobs-api,jobs-cli] Support services in jobs
 ResolveddcaroT359804 [jobs-api] Refactor before webservice support
 ResolveddcaroT359806 [jobs-api] Remove flask-restful

Event Timeline

dcaro created this task.Mar 11 2024, 11:50 AM
dcaro triaged this task as High priority.Mar 11 2024, 12:52 PM
dcaro moved this task from Backlog to Ready to be worked on on the Toolforge board.
dcaro changed the task status from Open to In Progress.Mar 18 2024, 5:48 PM
dcaro claimed this task.
dcaro moved this task from Ready to be worked on to Toolforge iteration 07 on the Toolforge board.
dcaro edited projects, added: Toolforge (Toolforge iteration 07); removed: Toolforge.
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 07) board.
CodeReviewBot added a project: Patch-For-Review.Mar 18 2024, 6:13 PM

dcaro opened https://gitlab.wikimedia.org/repos/cloud/toolforge/jobs-api/-/merge_requests/67

remove flask restful

dcaro moved this task from In Progress to In Review on the Toolforge (Toolforge iteration 07) board.Mar 20 2024, 2:21 PM
dcaro edited projects, added: Toolforge (Toolforge iteration 08); removed: Toolforge (Toolforge iteration 07).Apr 3 2024, 4:14 PM
dcaro moved this task from Next Up to In Review on the Toolforge (Toolforge iteration 08) board.
CodeReviewBot added a comment.Apr 8 2024, 10:11 AM

project_1317_bot_df3177307bed93c3f34e421e26c86e38 opened https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/234

jobs-api: bump to 0.0.276-20240408100952-62ee8ffb

dcaro closed this task as Resolved.Apr 8 2024, 12:33 PM
dcaro moved this task from In Review to Done on the Toolforge (Toolforge iteration 08) board.
CodeReviewBot added a comment.Apr 9 2024, 10:47 AM

dcaro merged https://gitlab.wikimedia.org/repos/cloud/toolforge/toolforge-deploy/-/merge_requests/234

jobs-api: bump to 0.0.276-20240408100952-62ee8ffb

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits