Write null to cu_private_event.cupe_actor if temporary accounts are enabled and the performer is an IP address
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• Dreamy_Jazz
	Mar 12 2024, 5:05 PM

Description

In T359873: Make the cupe_private column nullable it will be made possible to write NULL to the cupe_actor column of the cu_private_event table. This is to allow IP addresses to be the performer of events in that table without having to have an actor ID. A value of NULL will cause the interfaces to treat the performer of the event as the IP address in the cupe_ip column.

In this task, the CheckUserInsert service should be updated to set the cupe_actor column to NULL if temporary accounts are enabled and the performer is an IP address. This should be dependent on T359873 but that schema change does not need to be on WMF wikis for this ticket to be worked on as temporary accounts are not enabled on any WMF wikis which prevents this value being used on any WMF wikis until this is resolved (as this is a blocker for testwiki release).

Acceptance criteria

NULL should the value of cupe_actor if the performer is an IP address and temporary accounts are enabled

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T359962 here

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Write NULL to cupe_actor in specific circumstances	mediawiki/extensions/CheckUser	master	+111 -19

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	• Dreamy_Jazz	T353953 Don't use actor IDs for private CheckUser events when these actions are performed by IP addresses
Resolved	• Dreamy_Jazz	T359965 Update Special:CheckUser to handle 'NULL' as the value of cupe_actor in some of the rows of cu_private_event
Resolved	• Dreamy_Jazz	T359962 Write null to cu_private_event.cupe_actor if temporary accounts are enabled and the performer is an IP address
Resolved	• Dreamy_Jazz	T359873 Make the cupe_private column nullable
		· · ·

Event Timeline

• Dreamy_Jazz created this task.Mar 12 2024, 5:05 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2024, 5:05 PM

• Dreamy_Jazz added a subtask: T359873: Make the cupe_private column nullable.Mar 12 2024, 5:05 PM

• Dreamy_Jazz updated the task description. (Show Details)

Change 1010591 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Write NULL to cupe_actor in specific circumstances

https://gerrit.wikimedia.org/r/1010591

gerritbot added a project: Patch-For-Review.Mar 12 2024, 5:16 PM

• Dreamy_Jazz added a parent task: T359965: Update Special:CheckUser to handle 'NULL' as the value of cupe_actor in some of the rows of cu_private_event.Mar 12 2024, 5:26 PM

• Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.

• Dreamy_Jazz set the point value for this task to 2.Mar 13 2024, 12:29 PM

Change 1010591 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Write NULL to cupe_actor in specific circumstances

https://gerrit.wikimedia.org/r/1010591

Suggested QA steps intended for a local wiki:

Install CheckUser, if required
Enable temporary accounts, if required
Add $wgCheckUserLogLogins = true; to your LocalSettings.php if not already defined there
Make a failed login attempt to an account (i.e. use a wrong username or password)
Verify that no exception is thrown and instead an message is displayed indicating that the wrong password/username was used
Open the DB for your wiki
Find the last row that was inserted (which should the failed login attempt) and verify that the cupe_actor column is defined as NULL.

You can repeat this with step 4 and 5 replaced with using the Special:PasswordReset form and verifying that no exception is thrown. For step 7 you would expect to find a row for the password reset email being sent.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 18 2024, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2024, 3:30 PM

• Dreamy_Jazz closed subtask T359873: Make the cupe_private column nullable as Resolved.Mar 19 2024, 3:46 PM

@Dreamy_Jazz Cupe_actor is defined as NULL with an incorrect password as seen in the screenshots. Also password reset email being sent is shown when using select * FROM cu_private_event;. I will move this to Done. Thanks for all your work and steps!

Status: ✅PASS
Environment: Local: 1.42.0-alpha (24d0d95) 10:06, 19 March 2024; CheckUser- 2.5 (dc0ec3b) 15:07, 19 March 2024
OS: macOS Sonoma 14.4
Browser: Chrome 122
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/w/index.php?title=Special:UserLogin&returnto=Main+Page
Special:PasswordReset