Update Special:CheckUser to handle 'NULL' as the value of cupe_actor in some of the rows of cu_private_event
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Mar 12 2024, 5:26 PM

Description

Special:CheckUser needs to be updated to be able to handle NULL as the value of cupe_actor in some cu_private_event rows. This allows the interface to be able to display private events (such as failed login attempts) on a wiki with temporary accounts enabled which are performed by IP addresses.

Acceptance criteria

The Special:CheckUser pagers and interfaces should be updated to parse NULL as the value of cupe_actor through the use of a LEFT JOIN.

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T359965 here

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Support NULL values of cupe_actor in Special:CheckUser	mediawiki/extensions/CheckUser	master	+93 -12

Customize query in gerrit

Related Objects
Search...

View Standalone Graph

This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Status	Assigned	Task
		· · ·
Resolved	Dreamy_Jazz	T353953 Don't use actor IDs for private CheckUser events when these actions are performed by IP addresses
Resolved	Dreamy_Jazz	T359965 Update Special:CheckUser to handle 'NULL' as the value of cupe_actor in some of the rows of cu_private_event
Resolved	Dreamy_Jazz	T359962 Write null to cu_private_event.cupe_actor if temporary accounts are enabled and the performer is an IP address
		· · ·

Event Timeline

Dreamy_Jazz created this task.Mar 12 2024, 5:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2024, 5:26 PM

Dreamy_Jazz added a subtask: T359962: Write null to cu_private_event.cupe_actor if temporary accounts are enabled and the performer is an IP address.Mar 12 2024, 5:26 PM

Change 1010869 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Support NULL values of cupe_actor in Special:CheckUser

https://gerrit.wikimedia.org/r/1010869

gerritbot added a project: Patch-For-Review.Mar 13 2024, 10:58 AM

Dreamy_Jazz moved this task from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Gangan (11th - 22nd March)) board.Mar 13 2024, 12:29 PM

Dreamy_Jazz set the point value for this task to 1.

Change 1010869 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Support NULL values of cupe_actor in Special:CheckUser

https://gerrit.wikimedia.org/r/1010869

Suggested QA steps intended for a local wiki:

Install CheckUser, if required
Enable temporary accounts, if required
Add $wgCheckUserLogLogins = true; to your LocalSettings.php if not already defined there
Make a failed login attempt to an account (i.e. use a wrong username or password)
Verify that no exception is thrown and instead an message is displayed indicating that the wrong password/username was used
Open Special:CheckUser and run a Get actions check on the IP address you used to make the failed login attempt
Verify that the failed login appears in the results list as the first item displayed.

You can repeat this with step 4 and 5 replaced with using the Special:PasswordReset form and verifying that form successfully submits. For step 7 you would expect to find the the password reset email event.

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 18 2024, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2024, 3:30 PM

@Dreamy_Jazz Both failed login and password emails sent both show up in Special:CheckUser as seen in the screenshots. This will be moved to Done. Thanks for all your work and steps!

Status: ✅PASS
Environment: Local: 1.42.0-alpha (24d0d95)10:06, 19 March 2024
OS: macOS Sonoma 14.4
Browser: Chrome 122, Firefox 123, Safari 17.3
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
Special:CheckUser
Special:PasswordReset