| • Scardenasmolinar | |
| Mar 12 2024, 11:48 PM |
| F57125970: Screenshot 2024-08-06 at 1.00.08 PM.png | |
| Aug 6 2024, 6:01 PM |
| F57120979: Screenshot 2024-08-05 at 3.20.04 PM.png | |
| Aug 6 2024, 2:19 PM |
| Restricted File | |
| Aug 6 2024, 2:16 PM |
| Restricted File | |
| Aug 6 2024, 2:16 PM |
| Restricted File | |
| Aug 6 2024, 2:14 PM |
In some rare cases, a revert conflict will happen when AutoModerator attempts to revert a change. When this happens, it should not revert the change, instead, it should log it so a human user takes action and reverts the revision (by solving the revert conflict).
In this investigation, we should determine whether we should log the revert conflicts or create a page (that will be watched by the admins) where we add a new entry whenever a revert conflict occurs.
| Subject | Author | Repo | Branch | Lines +/- | |
|---|---|---|---|---|---|
| [SPIKE]Automoderator should log revert conflicts[16H] | Kgraessle | mediawiki/extensions/AutoModerator | master | +33 -22 |
In the user-facing component of this log, we need to think about what actions to present the user. Maybe undo, diff and history.
Does Logstash provide us with any insight on how common this is? We should evaluate that first - if it's not a common occurrence I don't think this is worth prioritising.
Change #1060155 had a related patch set uploaded (by Kgraessle; author: Kgraessle):
[mediawiki/extensions/AutoModerator@master] [SPIKE]Automoderator should log revert conflicts[16H]
It is possible to create our own manual log entries for Automoderator that will log the revert conflict.
The manual here outlines how to set it up.
I also created a patch where you can test it out. Note I deleted some code from the job to make it always create the log entry.
I'm also attaching an image of what it looks like:
We can also specify tags that we want to filter on if we need to add any additional features/observability in the future.
I'm still not 100% clear on the dividing line for appropriate/inappropriate use of Special:Log. All of the docs seem to only talk about logging actions/interventions, though I didn't see any warnings about other uses. Maybe these could use a second set of eyes?
https://www.mediawiki.org/wiki/Help:Log
https://www.mediawiki.org/wiki/Manual:Log_actions
https://www.mediawiki.org/wiki/Manual:Logging_table
https://www.mediawiki.org/wiki/Manual:Logging_to_Special:Log
I did dig up an existing use that is kind of similar to the example here:
Copy patrol bot logs revisions that it thinks are potential copyright violations, but doesn't take any direct action on the revision itself.
https://en.wikipedia.org/wiki/Special:Log?type=pagetriage-copyvio&user=&page=&wpdate=&tagfilter=&wpfilters%5B%5D=newusers&wpFormIdentifier=logeventslist
Just wanted to highlight this question again - did we do any investigation on how common this has been on tr.wiki so far? With an average revert time of less than 3 seconds, a revert conflict seems exceedingly unlikely so I'm not sure how useful this would be to users (to the idea of putting it in Special:Log, which I figure is a user-facing rather than developer-facing location).
@Samwalton9-WMF In reality, this exploration was as much for T370806: [SPIKE]: Determine approach for informing moderators that an edit exceeded the threshold, but was not reverted [16HRS] as this particular task. I meant to note that in my previous comment.
Change #1060155 abandoned by Jsn.sherman:
[mediawiki/extensions/AutoModerator@master] [SPIKE]Automoderator should log revert conflicts[16H]