Page MenuHomePhabricator
Create Task
Maniphest T360018

TestResults: Replace testResults fetching state with equivalent getter
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

During https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/1005142 we've replaced the fetching boolean state with the promises of pending requests.
However, the getter getFetchingTestResults is necessary for the components FunctionReport and FunctionReportItem.

We should restore this getter and replace its previous functionality (returning a boolean state flag) with a different logic that asserts the fetching state from the promises.

Devices and Design (URLs or screenshots, if applicable):

  • Desktop: ...
  • Small screens/mobile: ...

Completion checklist

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add fetching state as a local flag instead of global gettermediawiki/extensions/WikiLambdamaster+36 -34
Customize query in gerrit

Event Timeline

gengh created this task.Mar 13 2024, 10:41 AM
gengh claimed this task.
gerritbot added a comment.Mar 13 2024, 11:26 AM

Change 1010874 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] Add fetching state as a local flag instead of global getter

https://gerrit.wikimedia.org/r/1010874

gerritbot added a project: Patch-For-Review.Mar 13 2024, 11:26 AM
gerritbot added a comment.Mar 13 2024, 5:15 PM

Change 1010874 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add fetching state as a local flag instead of global getter

https://gerrit.wikimedia.org/r/1010874

Maintenance_bot removed a project: Patch-For-Review.Mar 13 2024, 5:30 PM
ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.23; 2024-03-19).Mar 13 2024, 7:01 PM
Jdforrester-WMF triaged this task as Medium priority.Mar 13 2024, 8:15 PM
Jdforrester-WMF moved this task from To Triage to To deploy on the Abstract Wikipedia team board.
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Mar 21 2024, 11:40 AM
Jdforrester-WMF closed this task as Resolved.Apr 4 2024, 7:45 PM
Jdforrester-WMF added a project: Abstract Wikipedia Fix-It tasks.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits