Page MenuHomePhabricator

Dialog should open immediately and in a loading state
Closed, ResolvedPublicFeature

Assigned To
Authored By
Samwilson
Mar 15 2024, 11:30 AM
Referenced Files
F45950812: 2024-04-11_15-02-40.png
Apr 12 2024, 2:21 AM
F45950794: 2024-04-11_15-01-20.png
Apr 12 2024, 2:21 AM
F45950780: 2024-04-11_15-00-16.png
Apr 12 2024, 2:21 AM
F45950752: 2024-04-11_14-59-45.png
Apr 12 2024, 2:21 AM
F45950731: 2024-04-11_14-20-37.png
Apr 12 2024, 2:21 AM
F45950545: 2024-04-11_15-05-34.png
Apr 12 2024, 2:21 AM
F45950526: 2024-04-11_15-04-44.png
Apr 12 2024, 2:21 AM
F45950618: 2024-04-11_14-20-37.png
Apr 12 2024, 2:21 AM

Description

Feature summary (what you would like to be able to do and where):

As soon as AutosuggestSitelink is started (either after an edit when there's no sitelink, or by the user clicking on the tools menu link), the dialog should open and be immediately in the loading state. The API requests should be started then as well, and the loading state continue until the search results are back.

OOUI has a loading state for dialog windows, with the animated title bar.

Use case(s) (list the steps that you performed to discover that problem, and describe the actual underlying problem which you want to solve. Do not describe only a solution):

Benefits (why should this be implemented?):

Currently, the tools link turns grey while the search is carried out, then it turns blue again briefly, before the dialog is opened. This is confusing for the user, who can't see that anything is actually happening.

Task Description:

QA Results - Meta

Details

TitleReferenceAuthorSource BranchDest Branch
Add pending state on API callsrepos/commtech/autosuggest-sitelink!49samwilsonpending-statemain
feat: allow the user to link a wikidata item to an articlerepos/commtech/autosuggest-sitelink!45thierryw23open-dialog-immediately-and-in-a-loading-statemain
Keep link greyed out during loadingrepos/commtech/autosuggest-sitelink!44samwilsonrm-colormain
Customize query in GitLab

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Hello @Samwilson, I am working on this task !

I need a documentation for the Dialog and windows manager or any other documentation on the WIKI ecosystem that can help for this specific task !

@Samwilson Tested on 2G so I can see the loading. When clicking on the Autosuggestlink, the dialog opens immediately in the loading state when there's no site link. This will be moved to Done. Thanks for all your work!

Status: ✅PASS
Environment: https://meta.wikimedia.org/wiki/Main_Page
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 123, Safari 17.3
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://meta.wikimedia.org/wiki/Fund_drives/2005/Q4_planning/Translations/Fund_drive_notice-et

✅AC1: https://phabricator.wikimedia.org/T360184

ChromeFirefoxSafari
2024-04-11_14-20-37.png (953×1 px, 194 KB)
2024-04-11_15-04-44.png (993×1 px, 214 KB)
2024-04-11_15-05-34.png (907×1 px, 171 KB)
Vector 2022Vector2010MinveraMonobookTimeless
2024-04-11_14-20-37.png (953×1 px, 194 KB)
2024-04-11_14-59-45.png (1×3 px, 239 KB)
2024-04-11_15-00-16.png (930×1 px, 115 KB)
2024-04-11_15-01-20.png (1×2 px, 187 KB)
2024-04-11_15-02-40.png (1×1 px, 189 KB)