The wikipage.diff and wikipage.indicators hooks are documented twice on the JSDoc site, although they only appear once each on the JSDuck site
See:
The wikipage.diff and wikipage.indicators hooks are documented twice on the JSDoc site, although they only appear once each on the JSDuck site
See:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| docs: Remove duplicate hook documentation | mediawiki/core | master | +2 -20 |
The documentation in mediawiki.page.preview.js appeared during the JSDoc migration, in commit 2d4257305963, so it’s no surprise that it’s not duplicated in JSDuck. And during copying documentation around, it came that both copies are slightly different (minor punctuation and formatting differences), so they cannot automatically be de-duplicated. I see two options:
Thanks, @Tacsipacsi! That makes sense. I think it would be best to remove the doc blocks from mediawiki.page.preview.js so there's only one instance of the documentation.
Change #1017167 had a related patch set uploaded (by Alex Paskulin; author: Alex Paskulin):
[mediawiki/core@master] docs: Remove duplicate hook documentation
Change #1017167 merged by jenkins-bot:
[mediawiki/core@master] docs: Remove duplicate hook documentation