Page MenuHomePhabricator

#top fragment triggers DT's "This topic could not be found" notification
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

Comments
#top fragment is present in

  1. edit summaries when editing the lead section using a popular gadget
  2. links to talk pages on these pages themselves

Related tasks
T349653

Event Timeline

It only triggers if an element with that ID isn't present on the page, which #top isn't since it's not part of the default skin, so a fun part of this is that there's a lot of semi-broken links being generated by the enwiki default signature (and that gadget).

I wonder if the "right" fix here is to make Vector2022 have an <a id="top"> again...

Change 1012754 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/skins/Vector@master] Add a #top anchor to Vector 2022

https://gerrit.wikimedia.org/r/1012754

Change #1012754 abandoned by DLynch:

[mediawiki/skins/Vector@master] Add a #top anchor to Vector 2022

Reason:

WHATWG spec has special treatment for #top, so actually it's the kids who are wrong.

https://gerrit.wikimedia.org/r/1012754

Change #1013331 had a related patch set uploaded (by DLynch; author: DLynch):

[mediawiki/extensions/DiscussionTools@master] Add #top to the ignore list for checking for moved topics

https://gerrit.wikimedia.org/r/1013331

Change #1013331 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Add #top to the ignore list for checking for moved topics

https://gerrit.wikimedia.org/r/1013331

Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Kanban Board) board.
Ryasmeen edited projects, added Verified; removed Editing QA.