Page MenuHomePhabricator
Create Task
Maniphest T360337

CommunityConfiguration CI does not catch style issues
Closed, ResolvedPublic
Actions

Description

@Sgs added some nit-prefixed comments to https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1011094, and some of them caught my attention:

nit: the class name should follow the pattern: ext-communityConfiguration-EditSummaryDialog__dialog-actions

I can recall CI complaining about issues like this in GrowthExperiments, and I was surprised it didn't do that in CommunityConfiguration. I pinged @Sgs about this, and they noted:

@Sgs wrote in WMF Slack:
I can confirm common style linting is not working locally neither. Debugging now.

Filling this task to record the work.

Details

SubjectRepoBranchLines +/-
Add vue files to stylelint grunt taskmediawiki/extensions/CommunityConfigurationmaster+93 -14
Customize query in gerrit

Related Objects

Event Timeline

• Urbanecm_WMF created this task.Mar 18 2024, 3:53 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 18 2024, 3:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Mar 18 2024, 3:58 PM

Change 1012401 had a related patch set uploaded (by Sergio Gimeno; author: Sergio Gimeno):

[mediawiki/extensions/CommunityConfiguration@master] Add vue files to stylelint grunt task

https://gerrit.wikimedia.org/r/1012401

gerritbot added a project: Patch-For-Review.Mar 18 2024, 3:58 PM
gerritbot added a comment.Mar 18 2024, 7:00 PM

Change 1012401 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] Add vue files to stylelint grunt task

https://gerrit.wikimedia.org/r/1012401

• Urbanecm_WMF triaged this task as High priority.Mar 18 2024, 7:01 PM
• Urbanecm_WMF edited projects, added Growth-Team (Sprint 9 (Growth Team)); removed Growth-Team.
• Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 9 (Growth Team)) board.
• Urbanecm_WMF moved this task from Backlog to Migrate Special:EditGrowthConfig on the MediaWiki-extensions-CommunityConfiguration board.
Maintenance_bot removed a project: Patch-For-Review.Mar 18 2024, 7:30 PM
• Urbanecm_WMF edited projects, added Growth-Team (Sprint 10 (Growth Team)); removed Growth-Team (Sprint 9 (Growth Team)).Mar 19 2024, 2:40 PM
• Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 10 (Growth Team)) board.
• Urbanecm_WMF edited projects, added Growth-Team (Sprint 11 (Growth Team)); removed Growth-Team (Sprint 10 (Growth Team)).Apr 2 2024, 4:45 PM
• Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 11 (Growth Team)) board.
Etonkovidova added subscribers: Tacsipacsi, Etonkovidova.Apr 8 2024, 10:45 PM

Following the steps in the last comment from @Tacsipacsi on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1011094 - I got the following warning:

Screen Shot 2024-04-08 at 3.37.48 PM.png (886×3 px, 198 KB)

@Sgs - is it expected?

• Urbanecm_WMF added a comment.Apr 8 2024, 10:53 PM
In T360337#9699264, @Etonkovidova wrote:

Following the steps in the last comment from @Tacsipacsi on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1011094 - I got the following warning:

Screen Shot 2024-04-08 at 3.37.48 PM.png (886×3 px, 198 KB)

That warning looks like you're not logged in as an admin (pending T360919 and its engineering counterpart).

On second thought, this particular task can be probably closed without any further action. Its scope was to enforce CSS style rules in CommunityConfiguration repo. But, up2you.

Etonkovidova closed this task as Resolved.Apr 10 2024, 9:01 PM
In T360337#9699273, @Urbanecm_WMF wrote:
In T360337#9699264, @Etonkovidova wrote:

Following the steps in the last comment from @Tacsipacsi on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommunityConfiguration/+/1011094 - I got the following warning:

Screen Shot 2024-04-08 at 3.37.48 PM.png (886×3 px, 198 KB)

That warning looks like you're not logged in as an admin (pending T360919 and its engineering counterpart).

On second thought, this particular task can be probably closed without any further action. Its scope was to enforce CSS style rules in CommunityConfiguration repo. But, up2you.

@Urbanecm_WMF - I agree with closing the task.
At this point, it doesn't matter whether a user is admin or not (or even is logged in), since the functionality is pending T360919.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits