Page MenuHomePhabricator

Stop using DBAccessObjectUtils::getDBOptions in CampaignEvents
Closed, ResolvedPublic2 Estimated Story Points

Description

We will hard-deprecate this function before the branch cut in April 9th. So this needs to be fixed by that time. Here is an example of adoption in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/1008851/2/includes/Mentorship/Store/DatabaseMentorStore.php

This also implies queries done in those areas need to switch to SelectQueryBuilder which is not currently possible because ICampaignsDatabasedoesn't support ::newSelectQueryBuilder(). I wanted to do the work myself but due to these complexities, I'm not going to.

Event Timeline

Change #1017052 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/extensions/CampaignEvents@master] Replace usages of deprecated DBAccessObjectUtils::getDBOptions

https://gerrit.wikimedia.org/r/1017052

Change #1017052 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] Replace usages of deprecated DBAccessObjectUtils::getDBOptions

https://gerrit.wikimedia.org/r/1017052

vaughnwalters subscribed.

I have checked each special page in the campaign events extension to make sure that data is correctly displaying. Tested together with subtask T361026 - see testing notes at T361026#9728078. Marking as done / resolved.