To enable dark mode in OOUI (T364777), at least two changes are being made OOUI:
Adding support for rem units- Adding support for Codex 1.5.0 CSS variables
This task involves the work of testing the editing experiences the Editing Team is responsible so that we can identify and document any issues that these two changes the change to support Codex 1.5.0 CSS variables might've introduced.
Requirements
- ✅ Editing: generate a patch demo for the following patch https://gerrit.wikimedia.org/r/c/oojs/ui/+/1034592/4
- ✅ Editing: use the patch demo you'll have generated in "1." to enable Dark Mode in user preferences and test the following editing experiences:
- Visual editor (mobile + desktop)
- DiscussionTools (mobile + desktop)
- ✅ Editing: populate the first three columns in the === Issues table below with the issues you notice
- 📍Web + DST Teams: determine the cause of the issues the Editing Team will have identified in "1)"
- DST + Editing + Web Teams: work together to determine which team(s) are best equipped to address the issues we'll have identified in "1)" and "2)" determined causes for in "2)"
Timing
The Editing Team will work to have QA completed by Friday, June 21st.
Issues
Issue | Screenshot | Affected interface | Team responsible for fix | Status | Ticket (if needed) |
---|---|---|---|---|---|
Table header and cell content not visible | Visual Editor (mobile) | ✅ Resolved | |||
Table Caption not visible | Visual Editor (mobile) | ✅ Resolved | |||
Math nodes not visible | F44108368 | Visual Editor (mobile) | ✅ Resolved | ||
Table not rendering completely | Article read mode (mobile) | ✅ Resolved | |||
Reply Tool toolbar not visible | Reply Tool (mobile) | TBD | Re-test as part of T365509 | ||
Text labels within edit summary under not visible | Reply Tool (mobile) | TBD | Re-test as part of T365509 | ||
New Topic Tool toolbar not visible | New Topic Tool (mobile) | TBD | Re-test as part of T365509 | ||
Text labels within edit summary under not visible | New Topic Tool Tool (mobile) | TBD | Re-test as part of T365509 | ||
Affordance for editing/reporting a topic/section not visible: | Talk pages (mobile) | TBD | Re-test as part of T365509 | ||
Affordance for editing/reporting a comment not visible: | Talk pages (mobile) | TBD | Re-test as part of T365509 | ||
Icons are not visible because their color remain dark | Visual Editor (desktop and mobile) | web | ✅ Resolved | ||
Text is not visible in many dialogs | Visual Editor (desktop) | web for initial pass | ✅ Resolved | ||
Highlighted texts are invisible | Discussion Tool (desktop and mobile) | web | Re-test as part of T365509 | ||
Text in <kbd /> are not visible because of the color | Discussion Tool (desktop and mobile) | web | Re-test as part of T365509 | ||
Template texts are invisible: Example in screenshot is Notice box template | Visual Editor(desktop and mobile) | web | ✅ Resolved | ||
Central Notice texts, as well as bracket surrounding hide link. This works in automatic, but not dark mode because html.skin-theme-clientpref-os .notheme styling is applied, as opposed to html.skin-theme-clientpref-night .notheme | |||||