Page MenuHomePhabricator

Track edits that have been checked but not reverted by AutoModerator
Open, Needs TriagePublic

Description

From findings in T356100: Determine method for tracking edits that have been checked but not reverted by AutoModerator

We need to use a database table (T360144) to track change id/rev id, score fetch information (such as checked, retry count, merge failure, score, etc) We will need to prune this data, which isn't an option for logs. ORES uses a maintenance script to prune its tables, though there are weak guarantees around that. Recent changes prunes itself on save by firing a pruning job in ~1/10 save calls. We should use that same method to prune our tracking table. We can drop rows with change/rev id's lower than the lowest change/rev in the rc table.

Event Timeline

@jsn.sherman Is this still necessary, or does Logstash serve this purpose now?

@jsn.sherman Is this still necessary, or does Logstash serve this purpose now?

We no longer use a database table, so this no longer makes sense as written. However, we may still want a high level metric for the health/effectiveness of automoderator. For example; do we want to keep a counter of scorable edits and edits sucessfully scored to understand if the extension is largely doing it's job? The logstash data is useful for troubleshooting individual errors, but not tracking ephemeral problems or the big picture as it relates to our objectives