Page MenuHomePhabricator

Cite extension should use CSS variable for targeted li elements.
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The list item is highlighted but in a non-standard color.

What should have happened instead?:
Should use background-color-progressive-subtle design token

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

This has already been fixed in Minerva, so once this is merged we can remove the style in Minerva.

Event Timeline

Change #1013407 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/MinervaNeue@master] Upstream style to ext.cite.styles

https://gerrit.wikimedia.org/r/1013407

Change #1013410 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/Cite@master] Use design tokens in Cite extension

https://gerrit.wikimedia.org/r/1013410

Change #1013498 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Cite@master] Make use of LESS mixins in ext.cite.styles.less

https://gerrit.wikimedia.org/r/1013498

Change #1013410 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Use design tokens in Cite extension

https://gerrit.wikimedia.org/r/1013410

Change #1013498 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Make use of LESS mixins in ext.cite.styles.less

https://gerrit.wikimedia.org/r/1013498

Change #1013407 abandoned by Mabualruz:

[mediawiki/skins/MinervaNeue@master] Style has been upstreamed to ext.cite.styles

Reason:

this was included in https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/1014547

https://gerrit.wikimedia.org/r/1013407