Page MenuHomePhabricator

Stop producing a "legacy" build of Codex tokens and styles
Closed, ResolvedPublic3 Estimated Story Points

Description

Now that Codex has changed to use rem units for typography and relative sizing/spacing tokens, the "legacy" build that we have produced thus far has become redundant. It is now identical with the non-legacy build

We may need to make some additional changes to the way that we handle tokens or styles relating to font-size based on the outcome of T358038. But regardless of what we decide to do there, we should no longer need to maintain a separate, slightly-different build of the Codex tokens and styles.

However, we are in the process of introducing several new build artifacts relating to night mode support (the "experimental" build, mode-specific CSS variable overrides, etc).

In the interest of simplicity we should remove the legacy artifacts as well as all code needed to generate these files. Otherwise, we risk dealing with a combinatorial explosion of different modes/themes/component-specific styles and it's going to put a drag on development work.

Acceptance Criteria
  • Update the tokens build script to remove the "legacy" build (currently treated as a platform)
  • Remove all references to these files in other parts of Codex (component files, package.json, etc)
  • Remove all references to the legacy files in MediaWiki itself (skins, CodexModule.php, etc).

Event Timeline

Change #1023118 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[design/codex@main] build, tokens: Stop producing "legacy-" assets

https://gerrit.wikimedia.org/r/1023118

Change #1023122 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/skins/Vector@master] styles: Remove references to the legacy Codex build

https://gerrit.wikimedia.org/r/1023122

Change #1023122 merged by jenkins-bot:

[mediawiki/skins/Vector@master] styles: Remove references to the legacy Codex build

https://gerrit.wikimedia.org/r/1023122

Change #1023897 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/UniversalLanguageSelector@master] resources: Replace theme-wikimedia-ui-legacy with theme-wikimedia-ui

https://gerrit.wikimedia.org/r/1023897

Change #1023898 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/Translate@master] resources: Replace theme-wikimedia-ui-legacy with theme-wikimedia-ui

https://gerrit.wikimedia.org/r/1023898

Change #1023901 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[oojs/ui@master] build: Replace theme-wikimedia-ui-legacy with theme-wikimedia-ui

https://gerrit.wikimedia.org/r/1023901

Change #1023903 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/extensions/Popups@master] build: Remove references to theme-wikimedia-ui-legacy

https://gerrit.wikimedia.org/r/1023903

Change #1023903 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] build: Remove references to theme-wikimedia-ui-legacy

https://gerrit.wikimedia.org/r/1023903

Change #1023944 had a related patch set uploaded (by Eric Gardner; author: Eric Gardner):

[mediawiki/core@master] CodexModule: remove references to "legacy" Codex files

https://gerrit.wikimedia.org/r/1023944

Change #1023118 merged by Eric Gardner:

[design/codex@main] build, tokens: Remove all logic for the legacy build

https://gerrit.wikimedia.org/r/1023118

Change #1023898 abandoned by Eric Gardner:

[mediawiki/extensions/Translate@master] resources: Replace theme-wikimedia-ui-legacy with theme-wikimedia-ui

Reason:

Not immediately needed, but see https://phabricator.wikimedia.org/T363761 for more information.

https://gerrit.wikimedia.org/r/1023898

Change #1023897 abandoned by Eric Gardner:

[mediawiki/extensions/UniversalLanguageSelector@master] resources: Replace theme-wikimedia-ui-legacy with theme-wikimedia-ui

Reason:

See https://phabricator.wikimedia.org/T363762

https://gerrit.wikimedia.org/r/1023897

Change #1025849 had a related patch set uploaded (by LWatson; author: LWatson):

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849

Change #1025849 merged by jenkins-bot:

[mediawiki/core@master] Update Codex from v1.4.0 to v1.5.0

https://gerrit.wikimedia.org/r/1025849

@egardner was there anything left to do for this? Looks like there's still one open patch.

@egardner was there anything left to do for this? Looks like there's still one open patch.

Looking to get that merged in the next day or two.

Change #1023944 merged by jenkins-bot:

[mediawiki/core@master] CodexModule: Stop providing "legacy" builds of Codex styles

https://gerrit.wikimedia.org/r/1023944

egardner updated the task description. (Show Details)