Page MenuHomePhabricator

[Bug] Page previews gradient not working in night mode
Closed, ResolvedPublic1 Estimated Story Points

Description

Steps to reproduce

  1. On a deskop computer, go to the mobile site and enable night mode on eswiki
  2. Hover over a link

Expected results

  • Text should disappear in a gradient

Actual results

Screenshot 2024-03-25 at 11.58.12 AM.png (1×1 px, 804 KB)

Environments observed

everywhere

Check any additional observations

Who is this suitable for?

  • Someone who is already setup with MediaWiki
  • Someone who has contributed a Gerrit patch
  • Someone starting their MediaWiki development journey

Where is the code located
https://gerrit.wikimedia.org/g/mediawiki/extensions/Popups

Who can they contact if struggling?
@Jdlrobson

Derived Requirement

Ensure that the gradient effect in page previews works correctly in night mode, making the text legible and maintaining the intended visual design.

BDD

Feature: Page Previews Gradient in Night Mode

  Scenario: Ensure gradient effect in night mode
    Given the user has enabled night mode
    When the user hovers over a link to preview a page
    Then the gradient effect in the preview should work correctly
    And the text should be legible

Test Steps

Test Case 1: Ensure Gradient Effect in Night Mode

  1. On a desktop computer, go to the mobile site and enable night mode on eswiki.
  2. Hover over a link to preview a page.
  3. AC1: Confirm that the gradient effect in the preview works correctly and the text is legible.

QA Results - Beta

ACStatusDetails
1T360877#9823922

QA Results - PROD

ACStatusDetails
1T360877#9844683

Details

Related Changes in Gerrit:

Event Timeline

Jdlrobson set the point value for this task to 1.Apr 25 2024, 5:48 PM

Thank you for tagging this task with good first task for Wikimedia newcomers!

Newcomers often may not be aware of things that may seem obvious to seasoned contributors, so please take a moment to reflect on how this task might look to somebody who has never contributed to Wikimedia projects.

A good first task is a self-contained, non-controversial task with a clear approach. It should be well-described with pointers to help a completely new contributor, for example it should clearly pointed to the codebase URL and provide clear steps to help a contributor get setup for success. We've included some guidelines at https://phabricator.wikimedia.org/tag/good_first_task/ !

Thank you for helping us drive new contributions to our projects <3

Pulling into current sprint as we have bandwidth and this was estimated as a one pointer.

Change #1032546 had a related patch set uploaded (by Stoyofuku-wmf; author: Stoyofuku-wmf):

[mediawiki/extensions/Popups@master] Fix gradient for night mode

https://gerrit.wikimedia.org/r/1032546

Change #1032546 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Fix gradient for night mode

https://gerrit.wikimedia.org/r/1032546

Edtadros subscribed.

Test Result - Beta

Status: ✅ PASS
Environment: beta
OS: macOS Sonoma
Browser: Chrome
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Gradient Effect in Night Mode

  1. On a desktop computer, go to the mobile site and enable night mode on eswiki.
  2. Hover over a link to preview a page.
  3. AC1: Confirm that the gradient effect in the preview works correctly and the text is legible.

screenshot 370.png (303×318 px, 69 KB)

Test Result - PROD

Status: ✅ PASS
Environment: PROD
OS: macOS Sonoma 14.5
Browser: Chrome 125
Device: MBA
Emulated Device: NA

Test Artifact(s):

Test Steps

Test Case 1: Ensure Gradient Effect in Night Mode

  1. On a desktop computer, go to the mobile site and enable night mode on eswiki.
  2. Hover over a link to preview a page (ex. https://es.m.wikipedia.org/wiki/Harry_Potter?minervanightmode=1)
  3. AC1: Confirm that the gradient effect in the preview works correctly and the text is legible.

2024-05-29_16-55-12.png (385×399 px, 73 KB)

Jdlrobson claimed this task.