Page MenuHomePhabricator
Create Task
Maniphest T360886

Convert PageTriage options to json
Closed, ResolvedPublic
Actions

Description

Convert to JSON (can do this soon. all the JS left in the objects we declare is mw.msg stuff and some date stuff. i think we can rip that out and put it right after the object declaration. then the snapshot tests will still work, and we'll be left with a pure object with no functions inside of it)

Details

SubjectRepoBranchLines +/-
Convert deletion tags to JSONmediawiki/extensions/PageTriagemaster+894 -982
Remove the ability to configure tags onwiki [temporarily?]mediawiki/extensions/PageTriagemaster+1 -53
Convert tags to JSONmediawiki/extensions/PageTriagemaster+2 K -2 K
Convert all tag options to jsonmediawiki/extensions/PageTriagemaster+3 K -3 K
Customize query in gerrit

Related Objects
Search...

Event Timeline

Samwalton9-WMF created this task.Mar 25 2024, 12:05 PM
Samwalton9-WMF mentioned this in T333440: Fix code smells related to MediaWiki:PageTriageExternalTagsOptions.js.
gerritbot added a comment.May 18 2024, 4:11 PM

Change #1033226 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Convert all tag options to json

https://gerrit.wikimedia.org/r/1033226

Restricted Application added a project: Moderator-Tools-Team. · View Herald TranscriptMay 18 2024, 4:11 PM
gerritbot added a project: Patch-For-Review.May 18 2024, 4:11 PM
gerritbot added a comment.May 19 2024, 7:20 PM

Change #1033708 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Convert deletion tags to JSON

https://gerrit.wikimedia.org/r/1033708

gerritbot added a comment.May 19 2024, 7:27 PM

Change #1033226 abandoned by Sohom Datta:

[mediawiki/extensions/PageTriage@master] Convert all tag options to json

Reason:

Split into seperate patches

https://gerrit.wikimedia.org/r/1033226

gerritbot added a comment.May 19 2024, 7:50 PM

Change #1033699 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Remove the ability to configure tags onwiki [temporarily?]

https://gerrit.wikimedia.org/r/1033699

Samwalton9-WMF moved this task from Inbox to Triaged on the Moderator-Tools-Team board.May 20 2024, 3:18 PM
jsn.sherman moved this task from Triaged to Code review requests on the Moderator-Tools-Team board.May 23 2024, 7:30 PM

noting that @Soda requested review in discord

gerritbot added a comment.May 23 2024, 8:04 PM

Change #1033707 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/extensions/PageTriage@master] Convert tags to JSON

https://gerrit.wikimedia.org/r/1033707

Soda mentioned this in T366032: Grant Access to nda/logstash for Sohom Datta.May 27 2024, 9:52 PM
Scardenasmolinar assigned this task to Soda.May 29 2024, 7:22 PM
Scardenasmolinar edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Scardenasmolinar moved this task from Ready to Eng review on the Moderator-Tools-Team (Kanban) board.
PatchDemoBot added a comment.May 29 2024, 11:08 PM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/8a73eb239b/w

PatchDemoBot added a comment.May 30 2024, 12:44 AM

Test wiki created on Patch demo by SCardenas (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d42960cfac/w

jsn.sherman moved this task from Eng review to Done on the Moderator-Tools-Team (Kanban) board.May 30 2024, 10:58 AM
Novem_Linguae closed this task as Resolved.May 30 2024, 11:00 AM
gerritbot added a comment.May 30 2024, 11:14 AM

Change #1033699 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Remove the ability to configure tags onwiki [temporarily?]

https://gerrit.wikimedia.org/r/1033699

gerritbot added a comment.May 30 2024, 11:16 AM

Change #1033707 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Convert tags to JSON

https://gerrit.wikimedia.org/r/1033707

gerritbot added a comment.May 30 2024, 11:22 AM

Change #1033708 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Convert deletion tags to JSON

https://gerrit.wikimedia.org/r/1033708

Maintenance_bot removed a project: Patch-For-Review.May 30 2024, 11:31 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).May 30 2024, 12:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits