Page MenuHomePhabricator
Create Task
Maniphest T360927

communityconfiguration-editor-client-file-bug and communityconfiguration-editor-client-file-bug-link-content are lego messages
Closed, ResolvedPublicBUG REPORT
Actions

Description

communityconfiguration-editor-client-file-bug and communityconfiguration-editor-client-file-bug-link-content are a pair of "lego" messages. They are concatenated in run time.

The MediaWiki convention is to avoid lego messages because they cannot be reliably translated to many languages with different word order, etc.

If the message needs simple markup, it can be inserted into one message. If it needs complex markup, the complex markup parts should be inserted into the message using parameters ($1, $2, etc.)

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
EditorMessage: Avoid using a lego messageUrbanecmmediawiki/extensions/CommunityConfigurationmaster+9 -35
Customize query in gerrit

Event Timeline

Amire80 created this task.Mar 25 2024, 5:53 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 25 2024, 5:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Mar 25 2024, 8:55 PM

Change #1014117 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/CommunityConfiguration@master] EditorMessage: Avoid using a lego message

https://gerrit.wikimedia.org/r/1014117

gerritbot added a project: Patch-For-Review.Mar 25 2024, 8:55 PM
Urbanecm_WMF claimed this task.Mar 25 2024, 8:56 PM
Urbanecm_WMF edited projects, added: Growth-Team (Sprint 10 (Growth Team)); removed: Growth-Team.
Urbanecm_WMF subscribed.

Thanks for the report! Let's fix this :).

Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 10 (Growth Team)) board.Mar 25 2024, 8:56 PM
KStoller-WMF moved this task from Backlog to Needed before pilot release on the MediaWiki-extensions-CommunityConfiguration board.Mar 25 2024, 9:58 PM
gerritbot added a comment.Mar 27 2024, 10:29 AM

Change #1014117 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] EditorMessage: Avoid using a lego message

https://gerrit.wikimedia.org/r/1014117

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.25; 2024-04-02).Mar 27 2024, 11:00 AM
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 10 (Growth Team)) board.Mar 27 2024, 4:07 PM
KStoller-WMF triaged this task as High priority.Mar 27 2024, 4:07 PM
KStoller-WMF moved this task from QA to Code Review on the Growth-Team (Sprint 10 (Growth Team)) board.
Urbanecm_WMF moved this task from Code Review to QA on the Growth-Team (Sprint 10 (Growth Team)) board.Mar 27 2024, 4:10 PM
Urbanecm_WMF removed a project: Patch-For-Review.Mar 30 2024, 7:55 PM
Urbanecm_WMF edited projects, added: Growth-Team (Sprint 11 (Growth Team)); removed: Growth-Team (Sprint 10 (Growth Team)).Apr 2 2024, 4:44 PM
Urbanecm_WMF moved this task from Incoming to QA on the Growth-Team (Sprint 11 (Growth Team)) board.
Etonkovidova closed this task as Resolved.Apr 16 2024, 1:05 AM
Etonkovidova subscribed.Apr 16 2024, 1:08 AM

The current beta has "communityconfiguration-editor-client-file-bug": "If the problem persists consider [$1 filling an issue] in the bug reporting tool."

Screen Shot 2024-04-15 at 6.04.43 PM.png (3,172×646 px, 158 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits