Page MenuHomePhabricator

CI Blocker: Use of wfGetDB was deprecated in MediaWiki 1.39.
Closed, ResolvedPublic

Description

CI for Translate and CX / SX is blocked due to the above error.

See: https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php74-noselenium-docker/164932/console

14:42:22 5) MediaWiki\Extension\DiscussionTools\Tests\ThreadItemStoreTest::testInsertThreadItems with data set #4 ('cases/ThreadItemStore/5change...tation')
14:42:22 Use of wfGetDB was deprecated in MediaWiki 1.39. [Called from MediaWiki\Extension\DiscussionTools\Tests\ThreadItemStoreTest::testInsertThreadItems in /workspace/src/extensions/DiscussionTools/tests/phpunit/ThreadItemStoreTest.php at line 71]
....
14:42:22 9) MergeUserTest::testBasicMerge
14:42:22 Use of wfGetDB was deprecated in MediaWiki 1.39. [Called from MergeUser::mergeEditcount in /workspace/src/extensions/UserMerge/includes/MergeUser.php at line 78]
....
14:42:22 12) MergeUserTest::testMergeEditcount
14:42:22 Use of wfGetDB was deprecated in MediaWiki 1.39. [Called from MergeUser::mergeEditcount in /workspace/src/extensions/UserMerge/includes/MergeUser.php at line 78]
`

See patches:

  1. 1013244: SX SectionSuggestion: Add isListable property and use it where needed | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/1013244
  2. 1007472: Add Echo notification to be sent on messages addition or removal | https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/1007472

Event Timeline

abi_ triaged this task as Unbreak Now! priority.Tue, Mar 26, 10:48 AM
abi_ created this task.

Change #1014487 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/DiscussionTools@master] Replace wfGetDB() in test with $this->getDb()

https://gerrit.wikimedia.org/r/1014487

Change #1014492 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/UserMerge@master] Replace use of wfGetDB()

https://gerrit.wikimedia.org/r/1014492

Change #1014492 merged by jenkins-bot:

[mediawiki/extensions/UserMerge@master] Replace use of wfGetDB()

https://gerrit.wikimedia.org/r/1014492

Change #1014487 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Replace wfGetDB() in test with $this->getDb()

https://gerrit.wikimedia.org/r/1014487

Change #1016738 had a related patch set uploaded (by Physikerwelt; author: Physikerwelt):

[mediawiki/extensions/MathSearch@master] Unbreak CI: replace usage of wfGetDB

https://gerrit.wikimedia.org/r/1016738

There are 700 more problems. As it is triaged as unbreak now, maybe reopening this issue is not the right thing to do, but I guess sooner the problems will pop up.

Change #1016738 merged by jenkins-bot:

[mediawiki/extensions/MathSearch@master] Unbreak CI: replace usage of wfGetDB

https://gerrit.wikimedia.org/r/1016738

There are 700 more problems. As it is triaged as unbreak now, maybe reopening this issue is not the right thing to do, but I guess sooner the problems will pop up.

No, this was an UBN task because it blocked WMF-production code. Non-production code doesn't get the same treatment for fixing deprecations; maintainers are expected to follow-up as they see fit, rather than us holding up everything.