Page MenuHomePhabricator

Special:Block form: Add 'Block details' field in Codex
Closed, ResolvedPublic

Description

Implement Block details field in Codex.

The component should look and feel as defined in Figma file

QA Results - Local

Event Timeline

Change #1015466 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Set up component for "Block Details" field

https://gerrit.wikimedia.org/r/1015466

Change #1015466 merged by jenkins-bot:

[mediawiki/core@master] Set up component for "Block Details" field

https://gerrit.wikimedia.org/r/1015466

@HMonroy I'm not sure if this is supposed to match exactly to Figma so I'm just going off the differences unless you tell me otherwise.

Status:❌FAIL
Environment: Local 1.43.0-alpha (01a6c18)17:31, 18 April 2024
OS: macOS Sonoma 14.4.1
Browser: Chrome 123
Skins. Vector 2022
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://meta.wikimedia.org/wiki/Bot

❌AC1: https://phabricator.wikimedia.org/T361147
Differences in Additional details

FigmaLocal
Block details (optional)Block details
description under Block details(optional)Nothing
FigmaLocal
2024-04-18_14-56-07.png (173Γ—629 px, 19 KB)
2024-04-18_14-55-41.png (136Γ—899 px, 17 KB)

@HMonroy No issues with Browsers or Skins when compared to Figma except in Safari as seen in the screenshot below since it doesn't have a check mark.

Status:❌FAIL
Environment: Local 1.43.0-alpha (ce9d259) 17:11, 22 April 2024
OS: macOS Sonoma 14.4.1
Browser: Chrome 123, Firefox 124, Safari 17.4
Skins. Vector 2022, Vector 2010, Minerva, Monobook, Timeless
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://meta.wikimedia.org/wiki/Bot

βœ… AC1: https://phabricator.wikimedia.org/T361147

FigmaChromeFirefox
2024-04-24_11-17-35.png (741Γ—1 px, 83 KB)
{
2024-04-24_11-26-51.png (445Γ—1 px, 96 KB)
2024-04-24_11-22-44.png (758Γ—2 px, 318 KB)

❌Issue- Safari doesn't check like Chrome and Firefox from above

2024-04-24_11-23-01.png (664Γ—2 px, 301 KB)

Was able to reproduce this on the Codex docs site with Safari Version 17.4.1 (19618.1.15.11.14), but it seems to be a browser bug.
When I uncheck the background-color property on the span carrying the check mark, while I'm inspecting the element, I can make the check mark appear again.

Was able to reproduce this on the Codex docs site with Safari Version 17.4.1 (19618.1.15.11.14), but it seems to be a browser bug.
When I uncheck the background-color property on the span carrying the check mark, while I'm inspecting the element, I can make the check mark appear again.

Sounds like that should be a separate task, then?