Page MenuHomePhabricator

Community Configuration: add "Review your changes" diff to Edit Summary dialog
Open, MediumPublic

Description

User story & summary:

As an editor of Community Configuration, I want to view a diff before I save a Configuration change, so that I can review the change.

Background & research:

This task is important because Community Configuration changes can be very impactful, and editors should be able to quickly visually confirm the change before saving the edit.

Design:

Dialog (10) (1) (1).png (294×518 px, 27 KB)

Dialog (11) (1) (1).png (446×627 px, 24 KB)

Figma designs

Acceptance Criteria:

Given I make a Community Configuration edit,
When I proceed to publish the change,
Then I see a "Review your changes" button in the Edit Summary.

Given I am viewing an Edit Summary of a Community Configuration change,
When I click "Review your changes",
Then I see a JSON summary of the change I've made (and I can Save changes or go Back)

Event Timeline

The task title is about the edit summary, the description is about the diff. Which one is a copy-paste error?

KStoller-WMF renamed this task from Community Configuration: Edit Summary improvements to Community Configuration: add "Review your changes" diff to Edit Summary.Apr 2 2024, 6:33 PM
KStoller-WMF renamed this task from Community Configuration: add "Review your changes" diff to Edit Summary to Community Configuration: add "Review your changes" diff to Edit Summary dialog.Apr 2 2024, 6:35 PM

The task title is about the edit summary, the description is about the diff. Which one is a copy-paste error?

I think it's just bad naming on my part. I've been referring to this whole dialog & associated diff as the "Edit Summary". Is there a more precise name?