Page MenuHomePhabricator

Fatal error when posting code review comment
Closed, ResolvedPublic

Description

4 PHP Catchable fatal error: Method MailAddress::__toString() must return a string value in /usr/local/apache/common-local/php-1.18/includes/UserMailer.php on line 128

https://www.mediawiki.org/wiki/Special:Code/MediaWiki/108768


Version: unspecified
Severity: major

Details

Reference
bz34158

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:08 AM
bzimport set Reference to bz34158.
bzimport added a subscriber: Unknown Object (MLST).

That is a bug in CodeReview. At some point it tries to send email to a null user which produce a null email address. That throw the fatal error in 1.18.

workaround backported from trunk to 1.18wmf1 with r110571

Should throw an exception instead to get a stack trace.

Weird...

$user->canReceiveEmail() should prevent this from happening...

(In reply to comment #2)

workaround backported from trunk to 1.18wmf1 with r110571

Should throw an exception instead to get a stack trace.

Didn't this fix it? Anyway 1.18 is unsupported now and CR is dead.