Back button doesn't close MediaViewer if the URL has a fragment with "/"
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Jack_who_built_the_house
	Apr 2 2024, 3:52 PM

Description

Steps to replicate the issue (include links if applicable):

Go to https://en.wikipedia.org/wiki/Open_access#Diamond/platinum_OA
Open any image
Press "Back" in the browser

What happens?:
Nothing

What should have happened instead?:
The image should close

Other information (browser name/version, screenshots, etc.):
Chrome

Details
This happens precisely when there is "/" in the URL fragment and doesn't happen otherwise. Probably MediaViewer confuses "/" with its own fragment (like /media/File:Open_Access_logo_PLoS_transparent.svg).

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Routing: Don't register a path for closing MMV	mediawiki/extensions/MultimediaViewer	master	+56 -39
	Back button doesn't close MediaViewer if the URL has a fragment with "/"	mediawiki/extensions/MultimediaViewer	master	+20 -2

Customize query in gerrit

Related Objects

Mentioned In: T376391: Can't close a map after opening an image

Event Timeline

Jack_who_built_the_house created this task.Apr 2 2024, 3:52 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 2 2024, 3:52 PM

Izno renamed this task from Back button doesn't close MediaViewer is the URL had a fragment with "/" to Back button doesn't close MediaViewer if the URL has a fragment with "/".Apr 3 2024, 4:50 AM

MediaViewer should be listening to router.on( 'route', (https://doc.wikimedia.org/mediawiki-core/master/js/OO.Router.html#.event:route) and closing itself when the hash is something that doesn't refer to itself.

Jdlrobson triaged this task as Medium priority.May 14 2024, 3:53 PM

Jdlrobson moved this task from Backlog to Triaged on the MediaViewer board.

Jdlrobson mentioned this in T376391: Can't close a map after opening an image.Oct 12 2024, 12:53 AM

Change #1079649 had a related patch set uploaded (by Simon04; author: Simon04):

[mediawiki/extensions/MultimediaViewer@master] Back button doesn't close MediaViewer if the URL has a fragment with "/"

https://gerrit.wikimedia.org/r/1079649

gerritbot added a project: Patch-For-Review.Oct 13 2024, 12:16 PM

Change #1079649 merged by jenkins-bot:

[mediawiki/extensions/MultimediaViewer@master] Back button doesn't close MediaViewer if the URL has a fragment with "/"

https://gerrit.wikimedia.org/r/1079649

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.28; 2024-10-22).Oct 17 2024, 12:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 17 2024, 12:30 AM

Jdlrobson closed this task as Resolved.Oct 17 2024, 2:32 AM

Jdlrobson claimed this task.

The patch above changes the route to /.*$/. While this works, such a generic path registration would conflict with any other app that tried to use the same approach.

In T361612#9795393, @Jdlrobson wrote:

MediaViewer should be listening to router.on( 'route', (https://doc.wikimedia.org/mediawiki-core/master/js/OO.Router.html#.event:route) and closing itself when the hash is something that doesn't refer to itself.

This is the better way to do it, as multiple apps can listen to the route event without conflicting.

Change #1080061 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/extensions/MultimediaViewer@master] Routing: Don't register a path for closing MMV

https://gerrit.wikimedia.org/r/1080061

gerritbot added a project: Patch-For-Review.Oct 22 2024, 2:41 PM

Esanders reopened this task as Open.Oct 22 2024, 2:41 PM

Change #1080061 merged by jenkins-bot: