testers that is already in the list should be a no-op
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	GrounderUK
	Apr 2 2024, 5:06 PM

Project Tags

Referenced Files

	F44190192: IMG_0915.png
	Apr 2 2024, 5:06 PM

	F44190193: IMG_0916.png
	Apr 2 2024, 5:06 PM

Subscribers

Description

Steps to replicate the issue (include links if applicable):

Go to https://www.wikifunctions.org/view/en/Z13909
Click ➕ in the “Tests” box

What happens?:
A new page opens with the single Implementation listed twice. The “Details” metadata is identical for both rows.
https://www.wikifunctions.org/w/index.php?title=Special:CreateObject&uselang=en&zid=Z20&Z20K1=Z13909

What should have happened instead?:
The new page should have listed the single Implementation just once,

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

Related Changes in Gerrit:

	Subject	Author	Repo	Branch	Lines +/-
	FunctionViewerDetailsTable: disable connect and disconnect buttons when loading	Daphne Smit	mediawiki/extensions/WikiLambda	master	+91 -10

Customize query in gerrit

Event Timeline

GrounderUK created this task.Apr 2 2024, 5:06 PM

Jdforrester-WMF added a project: WikiLambda Front-end.Apr 4 2024, 4:37 PM

• Mcastro triaged this task as Medium priority.Apr 4 2024, 4:37 PM

• Mcastro moved this task from To Triage to 24Q4 (Apr–Jun) on the Abstract Wikipedia team board.

• Mcastro edited projects, added: Abstract Wikipedia team (24Q4 (Apr–Jun)); removed: Abstract Wikipedia team.

Jdforrester-WMF moved this task from Incoming to Ready, Bugs on the Abstract Wikipedia team (24Q4 (Apr–Jun)) board.Apr 4 2024, 5:26 PM

Jdforrester-WMF moved this task from 24Q4 (Apr–Jun) to 25Q1 (Jul–Sep) on the Abstract Wikipedia team board.Jun 17 2024, 8:25 PM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q1 (Jul–Sep)); removed: Abstract Wikipedia team (24Q4 (Apr–Jun)).

Jdforrester-WMF moved this task from Incoming to Bugs to investigate on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Jun 17 2024, 8:31 PM

DSmit-WMF changed the task status from Open to In Progress.Jul 15 2024, 5:42 PM

DSmit-WMF claimed this task.

For some reason, two edits in quick succession added Z13911 twice to the Z8K4 on Z13909:

We can see that there are now two Z13909s in the Z8K4: https://www.wikifunctions.org/wiki/Z13909?action=raw

I clicked on "disconnect", which removed both, and then connected it again.
Disconnecting: https://www.wikifunctions.org/wiki/Z13909?uselang=en&diff=prev&oldid=114746
Connect: https://www.wikifunctions.org/wiki/Z13909?uselang=en&diff=prev&oldid=114747

That fixed the reported issue.

The underlying issue is that an already connected implementation shouldn't be added to the list of connected implementations. The PHP layer should just do nothing in that case (no error needs to bubble up I guess).

Renamed bug accordingly.

DVrandecic renamed this task from Duplicate Implementation rows when adding a Test case to Adding an implementation to the list of connected implementations that is already in the list should be a no-op.Jul 15 2024, 6:03 PM

The issue was also present on Z16053 and Z17506.

It also happens for tests. The following functions had duplicate tests: Z13163, Z13306, Z14573, Z14576, Z16919, and Z17506

For now, I fixed them all manually.

DVrandecic renamed this task from Adding an implementation to the list of connected implementations that is already in the list should be a no-op to Adding an implementation / tester to the list of connected implementations / testers that is already in the list should be a no-op.Jul 15 2024, 6:56 PM

DSmit-WMF removed DSmit-WMF as the assignee of this task.Jul 16 2024, 7:54 AM

DSmit-WMF subscribed.

DSmit-WMF changed the task status from In Progress to Open.Jul 16 2024, 12:31 PM

Jdforrester-WMF moved this task from 25Q1 (Jul–Sep) to 25Q2 (Oct–Dec) on the Abstract Wikipedia team board.Oct 8 2024, 2:02 PM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q2 (Oct–Dec)); removed: Abstract Wikipedia team (25Q1 (Jul–Sep)).

Jdforrester-WMF moved this task from Incoming to Bugs to investigate on the Abstract Wikipedia team (25Q2 (Oct–Dec)) board.Oct 8 2024, 2:08 PM

Jdforrester-WMF moved this task from 25Q2 (Oct–Dec) to 25Q3 (Jan–Mar) on the Abstract Wikipedia team board.Jan 15 2025, 8:16 PM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q3 (Jan–Mar)); removed: Abstract Wikipedia team (25Q2 (Oct–Dec)).

• Sharvaniharan moved this task from Incoming to Bugs to investigate on the Abstract Wikipedia team (25Q3 (Jan–Mar)) board.Jan 15 2025, 8:18 PM

Jdforrester-WMF moved this task from 25Q3 (Jan–Mar) to Bugs to investigate on the Abstract Wikipedia team board.Mar 24 2025, 4:03 PM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team; removed: Abstract Wikipedia team (25Q3 (Jan–Mar)).

The issue is that when the api call is still loading, the button still stays enabled. meaning the user can click the button as many times as he wants to connect or disconnect a tester or implementation. this will fire multiple api calls in a row.

If we want to still change the backend to prevent this.

Nothing to prevent from the PHP layer.
In this case, the Vue app is fully responsible of building this content and saving it.
The PHP layer is okay with [ "Z14", "Z13911", "Z13911" ] as long as that's a valid ZObject (which it is), so this falls fully on the button state handling side.

Change #1192564 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] FunctionViewerDetailsTable: disable connect and disconnect buttons when loading

https://gerrit.wikimedia.org/r/1192564

gerritbot added a project: Patch-For-Review.Sep 30 2025, 2:55 PM

DSmit-WMF changed the task status from Open to In Progress.Sep 30 2025, 2:55 PM

DSmit-WMF claimed this task.

DSmit-WMF moved this task from Bugs to investigate to 26Q1 (Jul–Sep) on the Abstract Wikipedia team board.

DSmit-WMF edited projects, added: Abstract Wikipedia team (26Q1 (Jul–Sep)); removed: Abstract Wikipedia team.

DSmit-WMF moved this task from Incoming to In Engineering on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

DSmit-WMF moved this task from In Engineering to In Code review on the Abstract Wikipedia team (26Q1 (Jul–Sep)) board.

Change #1192564 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] FunctionViewerDetailsTable: disable connect and disconnect buttons when loading

https://gerrit.wikimedia.org/r/1192564

Maintenance_bot removed a project: Patch-For-Review.Oct 7 2025, 8:31 AM

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.23; 2025-10-14).Oct 7 2025, 9:00 AM

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (26Q2 (Oct–Dec)); removed: Abstract Wikipedia team (26Q1 (Jul–Sep)).Oct 7 2025, 2:59 PM

Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.

Jdforrester-WMF added a project: Essential-Work.

Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (26Q2 (Oct–Dec)) board.Oct 15 2025, 9:43 PM

Tested on wikifunctions.org and confirmed it works as expected

DSmit-WMF closed this task as Resolved.Oct 23 2025, 10:33 AM

Adding an implementation / tester to the list of connected implementations / testers that is already in the list should be a no-opClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Adding an implementation / tester to the list of connected implementations / testers that is already in the list should be a no-op
Closed, ResolvedPublicBUG REPORT
Actions