Page MenuHomePhabricator

The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log.
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error
labels.normalized_message
The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log.
error.stack_trace
Notes

Patch mentioned in T360157#9677661. First observed when deploying wmf.25 train to group1. The error mentioned in the traces above only seems to have affected Slovekian wikis so far (skwikibooks, skwikiquote, etc) .Low error rate for the moment.

I can also see another of the errors mentioned in T360157#9677661. In this case it has affected eswikinews and frwikinews. Also low error rate so far. Example request:

labels.normalized_message
The option that uses the message key {msg_key_one} has the same translation as another option in {lang}. This means that {msg_key_one} will not be used as an option.
error.stack_trace

Details

Request URL
https://sk.wikibooks.org/wiki/%C5%A0peci%C3%A1lne:Z%C3%A1znamy/Wayiran
Related Changes in Gerrit:

Event Timeline

Using https://logstash.wikimedia.org/goto/8e66ad6c51d36cdc4afb9844758db4a9 I've two issues that need to be fixed:

  • patrol-log-page and review-logpage share the same translation in fr. They need to be different, otherwise the patrol log (defined in core - for example https://en.wikipedia.org/wiki/Special:Log/patrol) will not be shown as a valid log type if using the French language.
  • centralauth-rightslog-name and globalblocking-logpage share the same translation in sk. They need to be different for similar reasons to the previous.

I've updated https://translatewiki.net/wiki/MediaWiki:Review-logpage/fr which will fix the first issue in the next train.

Instead of reverting the patch, we could backport the translation change to https://translatewiki.net/wiki/MediaWiki:Review-logpage/fr. Alternatively, setting MediaWiki:Review-logpage to the updated translation on the wiki would also fix this if the log rate is unacceptable on frwiki.

I've blanked https://translatewiki.net/wiki/MediaWiki:Centralauth-rightslog-name/sk as this seems to be a incorrect translation (the text translated using google translate implies a block log, whereas the central auth log is for a rights log). This again will only be fixed on the next train unless the translation is manually set for the affected wikis.

Apart from logstash spam, this logstash error does not indicate a bug that didn't already exist for the last 16 years (?!)

@Dreamy_Jazz thank a lot for looking into it so quickly.

I'll keep an eye for new warnings tomorrow when I roll out the train to group2, if the message volume is too high we can backport some of the translation fixes. I'll follow up on this next week once all the fixes have landed in prod.

After train deploy to group2, elwiki and cewiki are also affected by some duplicated translation. I don't see any other wikis affected so far.

The error rate has increased a bit from group1 but I don't think it warrants a revert, we are currently seeing ~8 errs/min for these warnings.

Of the affected wikies, the noisiest one by far right now is skwiki, @Dreamy_Jazz would you be up for backporting the change for https://translatewiki.net/wiki/MediaWiki:Centralauth-rightslog-name/sk today? That would reduce the total noise a fair bit for the weekend.

After train deploy to group2, elwiki and cewiki are also affected by some duplicated translation. I don't see any other wikis affected so far.

Of the affected wikies, the noisiest one by far right now is skwiki, @Dreamy_Jazz would you be up for backporting the change for https://translatewiki.net/wiki/MediaWiki:Centralauth-rightslog-name/sk today? That would reduce the total noise a fair bit for the weekend.

Sure. I'll get a change merged for this.

Change #1017062 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CentralAuth@wmf/1.42.0-wmf.25] Remove sk translation of centralauth-rightslog-name

https://gerrit.wikimedia.org/r/1017062

Change #1017062 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.42.0-wmf.25] Remove sk translation of centralauth-rightslog-name

https://gerrit.wikimedia.org/r/1017062

Mentioned in SAL (#wikimedia-operations) [2024-04-04T14:33:42Z] <dreamyjazz@deploy1002> Started scap: Backport for [[gerrit:1017062|Remove sk translation of centralauth-rightslog-name (T361695)]]

Mentioned in SAL (#wikimedia-operations) [2024-04-04T14:36:01Z] <dreamyjazz@deploy1002> dreamyjazz: Backport for [[gerrit:1017062|Remove sk translation of centralauth-rightslog-name (T361695)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2024-04-04T14:48:32Z] <dreamyjazz@deploy1002> Finished scap: Backport for [[gerrit:1017062|Remove sk translation of centralauth-rightslog-name (T361695)]] (duration: 14m 49s)

The other translation issues which have appeared now:

I'm just putting this here for future knowledge (or future onlookers) and to explain somewhere why I took the action to delete the elwiki page.

Normally, stewards would not be able to act on non-gs wikis. Given the technical disruption level it was causing, I reluctantly deleted it after 5 days of no response from local admins. If this is as much a technical issue as highlighted, then this deletion should be performed from a staff account.

Dreamy_Jazz claimed this task.

Going to mark this as resolved, because all the logs I've seen in logstash have been addressed. The entries should reduce down to nothing once wmf.26 is out on all wikis.

With wmf.26 deployed to all wikis we still see quite a few logs for this kind of warnings. Right now they are among the most frequent we can see in the new errors board (after removing the three filters for T361695):

image.png (1,228×217 px, 63 KB)

I don't think hunting down every single translation key problem makes sense, but the new errors board is one of the first places we (RelEng) go to check the status of deployments and we should try to reduce noise there before we can close this. French and Spanish wikinews seem to be the most affected, probably those two are the ones we can tackle for now. A key with name logeventslist-patrol-log is affecting both :

  • frwikinews: The option that uses the message key logeventslist-patrol-log has the same translation as another option in fr
  • eswikinews: The option that uses the message key logeventslist-patrol-log has the same translation as another option in es

I'm also noting here other wikis affected by lower volume warnings which we can probably ignore:

  1. The option that uses the message key {msg_key_one} has the same translation as another option in {lang}. This means that {msg_key_one} will not be used as an option
    • hifwiktionary, pswiki, thwiki, kawikibooks, kawikiquote, twwiki
  2. The group {group_one} has the same translation as {group_two} for {lang}. {group_one} will not be displayed in group dropdown of the UsersPager
    • cewiki, diqwiki, ruewiki, pmswiki, diqwiktionary, iswikiquote, iswiktionary
  3. The log type {log_type_one} has the same translation as {log_type_two} for {lang}. {log_type_one} will not be displayed in the drop down menu on Special:Log
    • frrwiki

Thank you @Dreamy_Jazz . I can close this next week when wmf.27 is fully deployed.

I don't think hunting down every single translation key problem makes sense…

I don't see why not :) I see the following 20 low-frequency cases:

{"group_one":"autoeditor","group_two":"autoreview","lang":"ce"}
{"group_one":"autoreview","group_two":"autoeditor","lang":"ce"}
{"group_one":"bureaucrat","group_two":"sysop","lang":"is"}
{"group_one":"checkuser","group_two":"patroller","lang":"ltg"}
{"group_one":"checkuser","group_two":"steward","lang":"pms"}
{"group_one":"checkuser","group_two":"suppress","lang":"diq"}
{"group_one":"checkuser","group_two":"suppress","lang":"rue"}
{"group_one":"editor","group_two":"reviewer","lang":"is"}
{"group_one":"reviewer","group_two":"editor","lang":"is"}
{"log_type_one":"managetags","log_type_two":"tag","lang":"frr"}
{"msg_key_one":"abusefilter-list-options-deleted-only","lang":"ka"}
{"msg_key_one":"abusefilter-list-options-deleted-only","lang":"xmf"}
{"msg_key_one":"log-action-filter-delete-event","lang":"mai"}
{"msg_key_one":"log-action-filter-delete-event","lang":"ps"}
{"msg_key_one":"log-action-filter-upload-overwrite","lang":"th"}
{"msg_key_one":"next","lang":"nqo"}
{"msg_key_one":"protectedpages-cascade","lang":"myv"}
{"msg_key_one":"redirect-page","lang":"hif"}
{"msg_key_one":"redirect-revision","lang":"tw"}
{"msg_key_one":"restriction-level-sysop","lang":"udm"}

I'll go through them, following the example that @Dreamy_Jazz set (marking the translations with !!FUZZY!!, which should cause them to be removed from the .json files and suggest them for re-translation, and documenting in qqq that they need to be translated differently).

I went through the groups, made some edits: https://translatewiki.net/wiki/Special:Contributions/Matma_Rex. Messages requiring action on-wiki:

I think I've done them all. (It got a bit tiresome near the end, and I didn't add qqq documentation to every message – it didn't seem worth it since they didn't look ambiguous to me, I think some translations were just copied without anyone reading them.)

@matmarex, thanks for dealing with the renaming duplications.

@matmarex I wasn't expecting anyone to go through every single duplicated translation. Thank you so much for taking the time to do that! :D

…
I'll go through them, following the example that @Dreamy_Jazz set (marking the translations with !!FUZZY!!, which should cause them to be removed from the .json files and suggest them for re-translation, and documenting in qqq that they need to be translated differently).

I went through the groups, made some edits: https://translatewiki.net/wiki/Special:Contributions/Matma_Rex. Messages requiring action on-wiki:

  • …

Updates:

Unfortunately there is no way to skip export without deleting the translation from translatewiki.net. We could use FUZZY with the English source text which would give translators easy access to the previous translations.

@Nikerabbit Can you have a look at https://translatewiki.net/wiki/FAQ#!!FUZZY!! and at https://translatewiki.net/wiki/Quick_guide_to_editing_translatewiki.net and update them to describe what !!FUZZY!! actually does these days (if it does anything at all)? [or at least delete the parts that are wrong :) ]

Would it work like I want if I removed the translations manually from the .json files in Git? Or can you suggest some other way to fix this problem, other than removing the translations completely on translatewiki.net? (I can do that if nothing else works, I'd just prefer some other solution that is less disruptive)

https://translatewiki.net/wiki/FAQ#!!FUZZY!! seems correct. I was actually not aware of https://translatewiki.net/wiki/Quick_guide_to_editing_translatewiki.net but it's definitely incorrect.

FUZZY is just a way to manually mark messages outdated. That status is actually stored in a separate database table. Some file formats like Gettext support showing the fuzzy status, some like MediaWiki Json doesn't. Outdated messages are not excluded from exports.

Like I said, you can use FUZZY and replace the translation with the source text. Anyone reviewing the message has easy way to access the history with old translations (and see the edit summary).

Alright, I did that, hope it works.

We are still seeing a few of these warnings for 1.43.0-wmf.2 but the current volume is very low. From my side I'm happy to close this task.

@matmarex what do you think?

I cannot see any of these warnings for 1.43.0-wmf.2 on the new errors dashboard, but I might have missed them. If there are more, it makes sense to fix them now as the error rate would increase if pageviews increased (so the error rate is not stable and could spike at a later date). I'm happy to address the other translation issues.

We could wait until 1.43.0-wmf.2 is on group2 before resolving this just in case there are still some that only occur on group2 wikis? However, I'd be happy to close this now.

I cannot see any of these warnings for 1.43.0-wmf.2 on the new errors dashboard

Oops, yeah sorry, the errors I was seeing are actually 1.43.0-wmf.1

wmf.2 was promoted to all wikis a few hours ago, I see no errors since then: https://logstash.wikimedia.org/goto/61a9e60577b9ed696ed917a2aa94aef0

thcipriani subscribed.

Seeing these again for the past few MediaWiki versions

Fresh example (for some reason I can't find a stacktrace or reqId for this particular error in Logstash?):

Error
labels.normalized_message
The group {group_one} has the same translation as {group_two} for {lang}. {group_one} will not be displayed in group dropdown of the UsersPager.

Looks like group-abusefilter and group-abusefilter-helper have the same translation in uz. I've fixed this by removing the translation in https://translatewiki.net/w/i.php?title=MediaWiki:Group-abusefilter-helper/uz&diff=prev&oldid=12436757

Should translatewiki.net consider adding a validator that the messages that must be different are in fact different?

It might be useful to do that, but knowing which messages these actually are could be difficult.

I've fixed several more, but not been able to resolve 17 of the hits from the last 30 days as I couldn't find where the duplicate translations were.

Just noting that this was spotted again today prior to group2 promotion of wmf.8.

Error

More importantly, thanks for working towards a longterm fix! <3

I had a look again after the wmf.8 deployment, and it looks like @Dreamy_Jazz's translation changes last week took care of everything – there is only one error on 1.43.0-wmf.8, and it's a new one:

The log type managetags has the same translation as tag for az. managetags will not be displayed in the drop down menu on Special:Log.

Fixed on Translatewiki: https://translatewiki.net/w/i.php?title=MediaWiki:Log-name-tag/az&diff=prev&oldid=12447610 and messaged the translator: https://translatewiki.net/wiki/User_talk:Nemoralis#Translation_of_"Tag_(management)_log"

I had a look again after the wmf.8 deployment, and it looks like @Dreamy_Jazz's translation changes last week took care of everything – there is only one error on 1.43.0-wmf.8, and it's a new one:

The log type managetags has the same translation as tag for az. managetags will not be displayed in the drop down menu on Special:Log.

Fixed on Translatewiki: https://translatewiki.net/w/i.php?title=MediaWiki:Log-name-tag/az&diff=prev&oldid=12447610 and messaged the translator: https://translatewiki.net/wiki/User_talk:Nemoralis#Translation_of_"Tag_(management)_log"

Do we want to backport a fix for this? There have been 6,000 of these errors and 1,000 in the last 3 hours.

Change #1040139 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/core@wmf/1.43.0-wmf.8] Blank translation of 'log-name-tag' in az

https://gerrit.wikimedia.org/r/1040139

Change #1040139 abandoned by Dreamy Jazz:

[mediawiki/core@wmf/1.43.0-wmf.8] Blank translation of 'log-name-tag' in az

Reason:

No longer needed

https://gerrit.wikimedia.org/r/1040139